New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lit-html] Expand documentation for TemplateResult
and render
.
#2849
Conversation
🦋 Changeset detectedLatest commit: f154b90 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
42fc198
to
e276e50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/lit-html/src/lit-html.ts
Outdated
* @param options | ||
* | ||
* For example, to render "Hello, Zoe!" to the container `document.body` where | ||
* the name "Zoe" is from a variable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to @justinfagnani 's point, this should say something like,
This example renders the text "Hello, Zoe!" inside a paragraph tag, appending it to the container document.body
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Adding verbatim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, otherwise LGTM.
Part of #1883
This is a documentation only PR which expands the jsdocs for
render
andTemplateResult
.Impact:
TemplateResult
is used and referenced very often and has very minimal documentation. This documentation aims to explain what aTemplateResult
is, and how to render it to DOM via the lit-htmlrender
function or the LitElement.render lifecycle method.render
function is brilliant and lost some documentation between Lit 1 -> Lit 2.To document these I referenced:
render
: https://lit.dev/docs/v1/lit-html/rendering-templates/render
: https://lit.dev/docs/v1/api/lit-html/templates/#renderrender
which document the container appending behavior.Screenshots
For example
render
hover over: