[all] Upgrade all package locks, includes TypeScript 4.4.2 #2113

aomarks · 2021-08-31T01:36:45Z

Upgrade all package locks. Includes TypeScript 4.3.5 -> 4.4.2.
Typing fixes for TypeScript 4.4.2 (mostly https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables)
Adds devDependency on new @types/web-ie11 package to address TS 4.4 changes document.createTreeWalker to only take three params, which is illegal in IE11 microsoft/TypeScript-DOM-lib-generator#1068
Upgrade xmldom to new @xmldom/xmldom due to [Security] now published as @xmldom/xmldom xmldom/xmldom#271
Pin the localize transform example to TypeScript ~4.3.5 due to (upstream TypeScript bug) Builds hang with typescript 4.4.2 rollup/plugins#983
Add missing @types/node dependency to internal-scripts (not sure why this wasn't an error before -- maybe the Node types were coming via a transitive dependency which was removed by an upgrade).
Minor @lit/localize-tools changes: don't run build as part of test script, use @lit/ssr bare module in test instead of relative path, trivial config file schema change from dependency upgrade.

…s test

changeset-bot · 2021-08-31T01:36:48Z

🦋 Changeset detected

Latest commit: 18bd187

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2021-08-31T01:37:07Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +16% (-1.06ms - +6.07ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +2% (-1.59ms - +2.04ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -1% - +12% (-0.34ms - +5.48ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +4% (-0.31ms - +0.47ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +2% (-2.06ms - +1.21ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +2% (-1.30ms - +1.38ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -1% - +2% (-5.03ms - +14.79ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -4% - +9% (-5.64ms - +12.04ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +2% (-5.62ms - +6.94ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -4% - +2% (-5.39ms - +2.22ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +4% (-20.19ms - +31.03ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-6.94ms - +11.88ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +3% (-21.73ms - +27.00ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1815
Commit: d86b8c5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	99.87ms - 102.62ms	-	unsure 🔍 -2% - +2% -1.59ms - +2.04ms	faster ✔ 22% - 25% 28.33ms - 32.82ms
tip-of-tree tip-of-tree	99.83ms - 102.20ms	unsure 🔍 -2% - +2% -2.04ms - +1.59ms	-	faster ✔ 22% - 25% 28.67ms - 32.94ms
previous-release previous-release	130.04ms - 133.60ms	slower ❌ 28% - 33% 28.33ms - 32.82ms	slower ❌ 28% - 33% 28.67ms - 32.94ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	800.33ms - 813.91ms	-	unsure 🔍 -1% - +2% -5.03ms - +14.79ms	faster ✔ 7% - 9% 63.97ms - 81.66ms
tip-of-tree tip-of-tree	795.02ms - 809.46ms	unsure 🔍 -2% - +1% -14.79ms - +5.03ms	-	faster ✔ 8% - 10% 68.51ms - 86.88ms
previous-release previous-release	874.26ms - 885.61ms	slower ❌ 8% - 10% 63.97ms - 81.66ms	slower ❌ 8% - 11% 68.51ms - 86.88ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.64ms - 823.98ms	-	unsure 🔍 -1% - +1% -6.94ms - +11.88ms	faster ✔ 6% - 8% 51.40ms - 72.79ms
tip-of-tree tip-of-tree	808.21ms - 821.48ms	unsure 🔍 -1% - +1% -11.88ms - +6.94ms	-	faster ✔ 6% - 9% 53.89ms - 75.23ms
previous-release previous-release	871.04ms - 887.76ms	slower ❌ 6% - 9% 51.40ms - 72.79ms	slower ❌ 7% - 9% 53.89ms - 75.23ms	-

lit-html-kitchen-sink

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1815
Commit: d86b8c5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	45.32ms - 50.18ms	-	unsure 🔍 -1% - +12% -0.34ms - +5.48ms	faster ✔ 22% - 33% 13.50ms - 22.23ms
tip-of-tree tip-of-tree	43.58ms - 46.79ms	unsure 🔍 -11% - +0% -5.48ms - +0.34ms	-	faster ✔ 27% - 36% 16.47ms - 24.40ms
previous-release previous-release	62.00ms - 69.24ms	slower ❌ 27% - 48% 13.50ms - 22.23ms	slower ❌ 36% - 55% 16.47ms - 24.40ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	126.00ms - 140.76ms	-	unsure 🔍 -4% - +9% -5.64ms - +12.04ms	unsure 🔍 -8% - +6% -10.79ms - +8.15ms
tip-of-tree tip-of-tree	125.32ms - 135.05ms	unsure 🔍 -9% - +4% -12.04ms - +5.64ms	-	unsure 🔍 -9% - +2% -12.19ms - +3.16ms
previous-release previous-release	128.76ms - 140.64ms	unsure 🔍 -6% - +8% -8.15ms - +10.79ms	unsure 🔍 -3% - +9% -3.16ms - +12.19ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	38.42ms - 43.58ms	-	unsure 🔍 -3% - +16% -1.06ms - +6.07ms	unsure 🔍 -10% - +11% -4.20ms - +4.53ms
tip-of-tree tip-of-tree	36.03ms - 40.95ms	unsure 🔍 -15% - +2% -6.07ms - +1.06ms	-	unsure 🔍 -16% - +4% -6.63ms - +1.95ms
previous-release previous-release	37.32ms - 44.35ms	unsure 🔍 -11% - +10% -4.53ms - +4.20ms	unsure 🔍 -5% - +17% -1.95ms - +6.63ms	-

lit-html-repeat

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1815
Commit: d86b8c5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.16ms - 13.73ms	-	unsure 🔍 -2% - +4% -0.31ms - +0.47ms	faster ✔ 8% - 15% 1.10ms - 2.26ms
tip-of-tree tip-of-tree	13.10ms - 13.63ms	unsure 🔍 -3% - +2% -0.47ms - +0.31ms	-	faster ✔ 8% - 15% 1.19ms - 2.33ms
previous-release previous-release	14.62ms - 15.63ms	slower ❌ 8% - 17% 1.10ms - 2.26ms	slower ❌ 9% - 18% 1.19ms - 2.33ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	379.58ms - 388.43ms	-	unsure 🔍 -1% - +2% -5.62ms - +6.94ms	faster ✔ 27% - 30% 145.06ms - 159.38ms
tip-of-tree tip-of-tree	378.88ms - 387.80ms	unsure 🔍 -2% - +1% -6.94ms - +5.62ms	-	faster ✔ 27% - 30% 145.70ms - 160.06ms
previous-release previous-release	530.59ms - 541.85ms	slower ❌ 37% - 42% 145.06ms - 159.38ms	slower ❌ 38% - 42% 145.70ms - 160.06ms	-

lit-html-template-heavy

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1815
Commit: d86b8c5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.35ms - 67.31ms	-	unsure 🔍 -3% - +2% -2.06ms - +1.21ms	faster ✔ 16% - 20% 12.52ms - 16.18ms
tip-of-tree tip-of-tree	65.45ms - 68.06ms	unsure 🔍 -2% - +3% -1.21ms - +2.06ms	-	faster ✔ 15% - 20% 11.91ms - 15.95ms
previous-release previous-release	79.14ms - 82.22ms	slower ❌ 19% - 25% 12.52ms - 16.18ms	slower ❌ 18% - 24% 11.91ms - 15.95ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	127.36ms - 133.24ms	-	unsure 🔍 -4% - +2% -5.39ms - +2.22ms	faster ✔ 12% - 17% 18.39ms - 26.92ms
tip-of-tree tip-of-tree	129.46ms - 134.31ms	unsure 🔍 -2% - +4% -2.22ms - +5.39ms	-	faster ✔ 11% - 16% 17.14ms - 25.00ms
previous-release previous-release	149.86ms - 156.05ms	slower ❌ 14% - 21% 18.39ms - 26.92ms	slower ❌ 13% - 19% 17.14ms - 25.00ms	-

reactive-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1815
Commit: d86b8c5

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.39ms - 73.05ms	-	unsure 🔍 -2% - +2% -1.30ms - +1.38ms	unsure 🔍 -0% - +4% -0.19ms - +2.49ms
tip-of-tree tip-of-tree	71.13ms - 73.24ms	unsure 🔍 -2% - +2% -1.38ms - +1.30ms	-	unsure 🔍 -1% - +4% -0.37ms - +2.60ms
previous-release previous-release	70.02ms - 72.12ms	unsure 🔍 -3% - +0% -2.49ms - +0.19ms	unsure 🔍 -4% - +0% -2.60ms - +0.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	806.09ms - 843.53ms	-	unsure 🔍 -2% - +4% -20.19ms - +31.03ms	unsure 🔍 -3% - +4% -20.54ms - +32.38ms
tip-of-tree tip-of-tree	801.92ms - 836.86ms	unsure 🔍 -4% - +2% -31.03ms - +20.19ms	-	unsure 🔍 -3% - +3% -25.09ms - +26.09ms
previous-release previous-release	800.18ms - 837.59ms	unsure 🔍 -4% - +2% -32.38ms - +20.54ms	unsure 🔍 -3% - +3% -26.09ms - +25.09ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	867.16ms - 900.01ms	-	unsure 🔍 -2% - +3% -21.73ms - +27.00ms	unsure 🔍 -2% - +3% -16.60ms - +28.27ms
tip-of-tree tip-of-tree	862.95ms - 898.94ms	unsure 🔍 -3% - +2% -27.00ms - +21.73ms	-	unsure 🔍 -2% - +3% -20.41ms - +26.81ms
previous-release previous-release	862.46ms - 893.04ms	unsure 🔍 -3% - +2% -28.27ms - +16.60ms	unsure 🔍 -3% - +2% -26.81ms - +20.41ms	-

_{tachometer-reporter-action v2 for Benchmarks}

rictic · 2021-08-31T02:05:54Z

packages/lit-html/src/lit-html.ts

+    // entityReferenceExpansion parameter. This is the previous signature.
+    entityReferenceExpansion?: boolean
+  ) => TreeWalker
+)(d, 129 /* NodeFilter.SHOW_{ELEMENT|COMMENT} */, null, false);


This seems awkward in comparison to just depending on the IE11 types.

Another nice part about depending on IE11 types is that if/when we drop IE11 support, we can drop those types and the error will let us know we can drop this hack

True, done.

~~We will need to add this dependency, or write a patch, when we next import into google3, though.~~

Actually I guess not until we upgrade the TS version.

PTAL @rictic

rictic · 2021-08-31T02:07:02Z

packages/localize/examples/transform/package.json

@@ -20,6 +20,6 @@
    "rollup": "^2.41.1",
    "rollup-plugin-summary": "^1.3.0",
    "rollup-plugin-terser": "^7.0.2",
-    "typescript": "^4.3.5"
+    "typescript": "~4.3.5"


Is this what we want to do here long term?

Nope, but the typescript rollup plugin is totally broken with TypeScript 4.4, see rollup/plugins#983

I see. Too bad there's no comments allowed in json files :/

We do want to keep the typescript constraint as a ~x.y.z though, so this is great. We should have had that before, but relied on the package lock...

aomarks added 9 commits August 30, 2021 18:01

Upgrade all package locks

da2272e

Typing fixes for TypeScript 4.4.2

d4596af

Pin localize example to ~4.3.5 due to rollup/plugins#983

38d9bf9

Add missing @types/node dependency to scripts

b2056eb

Trivial localize-tools schema updates

0e431a9

Remove extra build steps from localize tests

85b8642

Import ssr with bare module instead of relative path in localize-tool…

ac14984

…s test

Upgrade xmldom to new @xmldom/xmldom due to xmldom/xmldom#271

53c0e04

Add changeset

48e06ca

aomarks requested a review from justinfagnani as a code owner August 31, 2021 01:36

google-cla bot added the cla: yes label Aug 31, 2021

aomarks requested review from kevinpschaaf, rictic and sorvell August 31, 2021 01:37

rictic approved these changes Aug 31, 2021

View reviewed changes

Use @types/web-ie11 instead of cast for createTreeWalker

18bd187

aomarks requested a review from rictic August 31, 2021 02:13

aomarks merged commit 5b2f364 into main Aug 31, 2021

aomarks deleted the upgrade-deps branch August 31, 2021 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[all] Upgrade all package locks, includes TypeScript 4.4.2 #2113

[all] Upgrade all package locks, includes TypeScript 4.4.2 #2113

aomarks commented Aug 31, 2021 •

edited

changeset-bot bot commented Aug 31, 2021 •

edited

github-actions bot commented Aug 31, 2021 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

rictic Aug 31, 2021

aomarks Aug 31, 2021 •

edited

aomarks Aug 31, 2021

rictic Aug 31, 2021

aomarks Aug 31, 2021

rictic Aug 31, 2021

justinfagnani Aug 31, 2021

[all] Upgrade all package locks, includes TypeScript 4.4.2 #2113

[all] Upgrade all package locks, includes TypeScript 4.4.2 #2113

Conversation

aomarks commented Aug 31, 2021 • edited

changeset-bot bot commented Aug 31, 2021 • edited

🦋 Changeset detected

github-actions bot commented Aug 31, 2021 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

rictic Aug 31, 2021

Choose a reason for hiding this comment

aomarks Aug 31, 2021 • edited

Choose a reason for hiding this comment

aomarks Aug 31, 2021

Choose a reason for hiding this comment

rictic Aug 31, 2021

Choose a reason for hiding this comment

aomarks Aug 31, 2021

Choose a reason for hiding this comment

rictic Aug 31, 2021

Choose a reason for hiding this comment

justinfagnani Aug 31, 2021

Choose a reason for hiding this comment

aomarks commented Aug 31, 2021 •

edited

changeset-bot bot commented Aug 31, 2021 •

edited

github-actions bot commented Aug 31, 2021 •

edited

aomarks Aug 31, 2021 •

edited