Fixed autoIncrement incrementBy/startWith support in MySQL, H2, HSQLDB, and MariaDB

[tozogabee]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Mysql / MariaDB

Neither support specifying incrementBy, so that is now a validation error.

H2 / Hsql

In both databases, incrementBy and startWith were ignored in both createTable and addAutoIncrement changes. Both those should now be supported.

Things to be aware of

• Only impacts the given databases
• Should test that both createTable and addAutoIncrement work with with none, one, or both of incrementBy and startWith specified in both createTable and addAutoIncrement
• Should test for incrementBy not allowed in both createTable and addAutoIncrement

Things to worry about

• Nothing

[github-actions]

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   34m 51s ⏱️ + 5m 18s
  4 578 tests ±0    4 360 ✔️ ±0     218 💤 ±0  0 ❌ ±0 
54 108 runs  ±0  49 096 ✔️ ±0  5 012 💤 ±0  0 ❌ ±0 

Results for commit ee29021. ± Comparison against base commit 4fb56c5.

♻️ This comment has been updated with latest results.

[kataggart]

@nvoxland Can you update the PR name to better describe the fix in context of automating release notes when you review this one please? Thanks!

[XDelphiGrl]

• Changes improve handling of incrementBy and startWith attributes.
• New unit tests added.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

[th3lon3w0lf]

This change is breaking our liquibase version upgrade. I have a MySQL DB on which we had the incrementBy attribute in the changeset. Since this is a validation error now, removed the incrementBy attribute from changeset and now, liquibase fails with modified checksum error(Because the md5 is different in databasechangelog for this changeset prior to the removal). If I enable "runOnChange=true", that fails because the table already exists.

Ideally, I would expect the incrementBy attribute removal shouldn't cause a checksum difference error if the validation error is introduced for this.

Am I missing something? How to get past this error?

[pkoulerimarshmallow]

@th3lon3w0lf it's been a while since your post, but what seems to work is:

• Remove addAutoIncrement from your changeSet.
• Add validCheckSum: <the already applied checksum in your DATABASECHANGELOG to your changeSet.
• If needed use autoIncrement: true to the column you need auto-incremented.

For example:

              - column:
                  name: count
                  type: int
                  autoIncrement: true
                  constraints:
                    unique: true
                    nullable: false