Mysql and friends do not support incrementBy on addAutoIncrement #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDelphiGrl
reviewed
Jul 12, 2022
There was a problem hiding this comment.
Hi, @nvoxland - Did you not also need to add any of the associated validation files for these tests?
|
No, @XDelphiGrl, there were validation files already there which continue to work. For mysql/mariadb, we used to ignore the incrementBy field so there was nothing about it in the validation. Now I took those fields off on these database-specific overrides of default addAutoIncrement changelogs and the SQL for those remain the same. |
|
Thank you for the explanation about the validation files, @nvoxland . |
|
Since the core PR got merged, I have to merge this to develop to keep tests passing. If you have comments, I can make an additional PR with changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test updates for liquibase/liquibase#3026