Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Quality Checks command and subcommands (Mac specifict) #2273

Merged
merged 1 commit into from Feb 7, 2022

Conversation

szandany
Copy link
Contributor

@szandany szandany commented Dec 14, 2021

Environment

Liquibase Version: 4.6.1 and above.

Liquibase Integration & Version: CLI

Database Vendor & Version: Any

Operating System Type & Version: MacOS (Bash)

Pull Request Type

  • Enhancement/New feature (non-breaking change which adds functionality)

Description

Added auto-complete "checks" commands to the liquibase-dist/src/main/archive/lib/liquibase_autocomplete_mac.bash auto-complete scripts.


Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

Reviewed code

Test Requirements (Liquibase Internal QA)

Manual Tests

  • Verify auto-complete for the Quality Checks commands using a Mac terminal.
    • 'checks run'
    • 'checks delete --check-name=<check_short_name>'
    • 'checks bulk-set'
    • 'checks show'
    • 'checks customize --check-name=<check_short_name>'
    • 'checks reset --check-name=<check_short_name>'
    • 'checks enable --check-name=<check_short_name>'
    • 'checks disable --check-name=<check_short_name>'
    • 'checks copy --check-name=<check_short_name>'

Automated Tests

  • None required for this change.

@kataggart
Copy link
Contributor

@szandany would you mind completing questions/sections above to better describe this work? Thanks!

@szandany szandany assigned kataggart and unassigned szandany Jan 5, 2022
@kataggart kataggart changed the title Added new Quality Checks command and subcommands Added new Quality Checks command and subcommands (Mac specifict) Jan 18, 2022
@kataggart kataggart added this to To Do in Conditioning++ via automation Jan 18, 2022
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Jan 24, 2022
@kataggart kataggart removed their assignment Jan 28, 2022
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @szandany !

@XDelphiGrl XDelphiGrl self-assigned this Feb 4, 2022
@XDelphiGrl
Copy link
Contributor

XDelphiGrl commented Feb 4, 2022

CAUTION: This feature may not offer full tab completion in some Mac environments.


Sourcing the Mac AutoComplete Script
If you do not have the autocomplete persistently sourced, you need to source the script in the terminal where you are testing the autocomplete. Sourcing the script in this manner applies to the current console and does not transfer to any newly opened terminals.

source liquibase_autocomplete_mac.bash


  • To See a List of All Checks Subcommands in Most Environments
    • 'checks run' : Typing liquibase ch [tab][tab] results in a full list of checks commands with required parameters.

  • Full Set of Tab Completion for Check Subcommands (May Not Work in All Environments)
    • 'checks delete --check-name=<check_short_name>'
    • 'checks bulk-set'
    • 'checks show'
    • 'checks customize --check-name=<check_short_name>'
    • 'checks reset --check-name=<check_short_name>'
    • 'checks enable --check-name=<check_short_name>'
    • 'checks disable --check-name=<check_short_name>'
    • 'checks copy --check-name=<check_short_name>'

Test Environment
Liquibase Core: added-QualityChecks-MacOS/993/9cdc4f, Pro: master/227/d17d07
Passing Functional Tests (Internal): https://github.com/liquibase/liquibase-pro-tests/actions/runs/1578530594
Mac OS: Big Sur (11.4)

@nvoxland nvoxland merged commit c9dfcf0 into master Feb 7, 2022
Conditioning++ automation moved this from Code Review to Done Feb 7, 2022
@nvoxland nvoxland deleted the added-QualityChecks-MacOS branch February 7, 2022 20:31
@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants