Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quality Checks commands and subcommands #2272

Merged
merged 1 commit into from Feb 22, 2022
Merged

Conversation

szandany
Copy link
Contributor

@szandany szandany commented Dec 14, 2021

Liquibase Version: 4.6.1 and above.

Liquibase Integration & Version: CLI

Database Vendor & Version: Any

Operating System Type & Version: Unix/Linux (Bash)

Pull Request Type

  • Enhancement/New feature (non-breaking change which adds functionality)

Description

Added auto-complete "checks" commands to the liquibase-dist/src/main/archive/lib/liquibase_autocomplete.sh auto-complete scripts.


Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

Reviewed code

┆Issue is synchronized with this Jira Bug by Unito

@kataggart
Copy link
Contributor

@szandany did you mean to submit two of these? Is this the same as https://github.com/liquibase/liquibase/pull/2273?

@szandany
Copy link
Contributor Author

szandany commented Jan 5, 2022

@kataggart this change is for Linux/Unix - liquibase-dist/src/main/archive/lib/liquibase_autocomplete.sh
#2273 is for MacOS (bash specific) - liquibase-dist/src/main/archive/lib/liquibase_autocomplete_mac.bash

@kataggart kataggart added this to To Do in Conditioning++ via automation Jan 18, 2022
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Jan 24, 2022
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Feb 2, 2022
@yodzhubeiskyi
Copy link
Contributor

Manual Testing

Sourcing the Linux AutoComplete Script
If you do not have the autocomplete persistently sourced, you need to source the script in the terminal where you are testing the autocomplete. Sourcing the script in this manner applies to the current console and does not transfer to any newly opened terminals.

source lib/liquibase_autocomplete.sh

Verify liquibase correctly autocompletes checks commands.

  • type liquibase che [tab]
  • the result of autocompleting: liquibase checks
  • type liquibase checks^de [tab]
  • the result of autocompleting: checks delete --check-name=<check_short_name>
  • type liquibase checks^cu [tab]
  • the result of autocompleting: liquibase checks customize --check-name=<check_short_name>

@yodzhubeiskyi
Copy link
Contributor

Test results
Verify liquibase correctly autocompletes checks commands. PASS

Liquibase version [Core: //add-QC-commands-linux/992/358bf6/2021-12-14 14:58+0000, Pro: master/227/d17d07/2021-12-10T14:44:03Z] #992

@nvoxland nvoxland merged commit a001974 into master Feb 22, 2022
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Feb 22, 2022
@nvoxland nvoxland deleted the add-QC-commands-linux branch February 22, 2022 20:19
@kataggart kataggart modified the milestones: On Deck, NEXT Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants