Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.36 #897

Merged
merged 2 commits into from Apr 27, 2021
Merged

Bump MSRV to 1.36 #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4ab675
Bump MSRV to 1.36.0
TheBlueMatt Apr 26, 2021
5625c3a
Test lightning-persister on rustc 1.36 as well
TheBlueMatt Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -9,10 +9,10 @@ jobs:
platform: [ ubuntu-latest ]
toolchain: [ stable,
beta,
# 1.30.0 is MSRV for Rust-Lightning
1.30.0,
# 1.34.2 is Debian stable
1.34.2,
# 1.36.0 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister
1.36.0,
# 1.41.0 is Debian stable
1.41.0,
# 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation
1.45.2]
include:
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always
- name: Build on Rust ${{ matrix.toolchain }}
if: "! matrix.build-net-tokio"
run: cargo build --verbose --color always -p lightning && cargo build --verbose --color always -p lightning-invoice
run: cargo build --verbose --color always -p lightning && cargo build --verbose --color always -p lightning-invoice && cargo build --verbose --color always -p lightning-persister
- name: Build Block Sync Clients on Rust ${{ matrix.toolchain }} with features
if: "matrix.build-net-tokio && !matrix.coverage"
run: |
Expand All @@ -74,7 +74,7 @@ jobs:
run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always
- name: Test on Rust ${{ matrix.toolchain }}
if: "! matrix.build-net-tokio"
run: cargo test --verbose --color always -p lightning && cargo test --verbose --color always -p lightning-invoice
run: cargo test --verbose --color always -p lightning && cargo test --verbose --color always -p lightning-invoice && cargo build --verbose --color always -p lightning-persister
- name: Test Block Sync Clients on Rust ${{ matrix.toolchain }} with features
if: "matrix.build-net-tokio && !matrix.coverage"
run: |
Expand Down
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -75,8 +75,7 @@ be covered by functional tests.
When refactoring, structure your PR to make it easy to review and don't
hestitate to split it into multiple small, focused PRs.

The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and
GitHub Actions).
The Minimal Supported Rust Version is 1.36.0 (enforced by our GitHub Actions).

Commits should cover both the issue fixed and the solution's rationale.
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.
Expand Down