Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.36 #897

Merged
merged 2 commits into from Apr 27, 2021
Merged

Conversation

TheBlueMatt
Copy link
Collaborator

cc rust-bitcoin/rust-bitcoin#510 but basically I'm too lazy to actually fix CI and instead just figure we can go ahead and take the MSRV bump (though I'll dig if CI fails here too).

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #897 (5625c3a) into main (36570f4) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   90.29%   90.40%   +0.11%     
==========================================
  Files          57       57              
  Lines       29268    30010     +742     
==========================================
+ Hits        26427    27131     +704     
- Misses       2841     2879      +38     
Impacted Files Coverage Δ
lightning-invoice/src/de.rs 81.33% <0.00%> (-0.02%) ⬇️
lightning/src/ln/features.rs 98.92% <0.00%> (+<0.01%) ⬆️
lightning/src/ln/functional_tests.rs 96.85% <0.00%> (+0.03%) ⬆️
lightning-invoice/src/lib.rs 87.40% <0.00%> (+3.04%) ⬆️
lightning-invoice/src/ser.rs 91.75% <0.00%> (+7.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36570f4...5625c3a. Read the comment docs.

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK df91e67

.github/workflows/build.yml Outdated Show resolved Hide resolved
Debian is shipping 1.41 on oldstable and rust-bitcoin will likely
move to 1.36 over the coming months, so there's little reason to
wait on this.

cc rust-bitcoin/rust-bitcoin#510
@TheBlueMatt
Copy link
Collaborator Author

Full diff is only comments. Will merge after CI.

$ git diff-tree -U1 df91e675e 5625c3ab5
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6fcfc7379..341d3819f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -11,5 +11,5 @@ jobs:
                      beta,
-                     # 1.36.0 is MSRV for Rust-Lightning
+                     # 1.36.0 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister
                      1.36.0,
-                     # 1.34.2 is Debian stable
+                     # 1.41.0 is Debian stable
                      1.41.0,

@TheBlueMatt TheBlueMatt merged commit 7af9976 into lightningdevkit:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants