Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2970 Followups #3025

Closed
wants to merge 2 commits into from
Closed

#2970 Followups #3025

wants to merge 2 commits into from

Commits on Apr 25, 2024

  1. Drop PaymentContext from OnionPayload as its not needed 

    This saves some space on disk and a bit of space in memory, but
also avoids some unnecessary `clone`s. As this was added since the
last release there is no need for backwards compat handling.
    @TheBlueMatt
    TheBlueMatt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    98398fe View commit details
    Browse the repository at this point in the history

  2. Drop amount_msats from InvoiceRequestFields 

    An `InvoiceRequest` can overpay for an `Offer` which would be
reflected back to the recipient via the `amount_msats` field, but
its somewhat deceptive as the sender can *also* then further
overpay in the HTLC(s) themselves. The total overpayment is already
communicated in the `Event::ClaimablePayment` so we simply drop the
`InvoiceRequestFields` field here.

Fixes lightningdevkit#3002
    @TheBlueMatt
    TheBlueMatt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    90c919c View commit details
    Browse the repository at this point in the history