#2970 Followups #3025
Closed
#2970 Followups #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves some space on disk and a bit of space in memory, but also avoids some unnecessary `clone`s. As this was added since the last release there is no need for backwards compat handling.
An `InvoiceRequest` can overpay for an `Offer` which would be reflected back to the recipient via the `amount_msats` field, but its somewhat deceptive as the sender can *also* then further overpay in the HTLC(s) themselves. The total overpayment is already communicated in the `Event::ClaimablePayment` so we simply drop the `InvoiceRequestFields` field here. Fixes lightningdevkit#3002
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
+ Coverage 89.15% 89.22% +0.07%
==========================================
Files 118 118
Lines 97724 98153 +429
Branches 97724 98153 +429
==========================================
+ Hits 87122 87575 +453
+ Misses 8363 8341 -22
+ Partials 2239 2237 -2 ☔ View full report in Codecov by Sentry. |
|
Oops, this is broken in ways #3028 is not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3002. I went to go see if it was practical to do the first commit and by the time I finished checking if it was practical I'd basically written the commit anyway so figured I'd just open a PR instead of making someone else do it. Has to go in the same release or it'll be broken by backwards compat.