Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop electrsd's auto-download feature for good #3020

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Drop electrsd's auto-download feature for good #3020

wants to merge 4 commits into from

Commits on Apr 25, 2024

  1. Move CI downloading bitcoind/electrsd to dedicated shell script 

    ... allowing it to be sourced locally before running
`lightning-transaction-sync` tests.
    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5bf9062 View commit details
    Browse the repository at this point in the history

  2. Drop electrsd autodownload feature for good 

    ... which requires a bunch of unnecessary dev dependencies, e.g., `zip`.

Instead we lean on the `download_bitcoind_electrs.sh` script also for
local testing.
    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9a013a2 View commit details
    Browse the repository at this point in the history

  3. Have shellcheck check all scripts in ci

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    87ccc3f View commit details
    Browse the repository at this point in the history

  4. Fix misc shellcheck complaints

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    30c110b View commit details
    Browse the repository at this point in the history