Drop electrsd's auto-download feature for good
#3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-04-drop-electrsd-autodownload-for-good
branch
3 times, most recently
from
2cad4fb
to
baf30a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 89.13% 89.13% -0.01%
==========================================
Files 118 118
Lines 97678 97678
Branches 97678 97678
==========================================
- Hits 87066 87063 -3
- Misses 8370 8372 +2
- Partials 2242 2243 +1 ☔ View full report in Codecov by Sentry. |
... allowing it to be sourced locally before running `lightning-transaction-sync` tests.
tnull
force-pushed
the
2024-04-drop-electrsd-autodownload-for-good
branch
from
baf30a6
to
eeec14d
Compare
... which requires a bunch of unnecessary dev dependencies, e.g., `zip`. Instead we lean on the `download_bitcoind_electrs.sh` script also for local testing.
tnull
force-pushed
the
2024-04-drop-electrsd-autodownload-for-good
branch
from
eeec14d
to
30c110b
Compare
|
Thanks! Now that we have a script, can we run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which requires a bunch of unnecessary dev dependencies, e.g.,
zip.Instead we lean on the
download_bitcoind_electrs.shscript also for local testing.