Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update SpringBoot version in spring client sample #1425

Closed
wants to merge 1 commit into from
Closed

chore: update SpringBoot version in spring client sample #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/java-valueentity-counter-spring-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>2.7.8</version>
<version>3.0.2</version>
<relativePath/>
</parent>

Expand Down Expand Up @@ -52,7 +52,7 @@
<dependency>
<groupId>net.devh</groupId>
<artifactId>grpc-client-spring-boot-starter</artifactId>
<version>2.13.1.RELEASE</version>
<version>2.14.0.RELEASE</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another third party library to have grpc client. I'm just updating to last version.

Their README mention it is build with 2.6.13, https://github.com/yidongnan/grpc-spring-boot-starter#versions not clear if it will work with SpringBoot 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpringBoot 3 uses Spring Framework 6 and may not be compatible with the grpc starter.

https://github.com/yidongnan/grpc-spring-boot-starter/issues/826

If that's the case, version 2.13.1 won't be a good fit either and we will have to keep this sample on SpringBoot 2.7.8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tests failing with

java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
	at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27)
Caused by: java.lang.ClassNotFoundException: javax.servlet.DispatcherType
	at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27

We won't be able to update this sample for now. Unless grpc-spring-boot-starter gets updated or we have another solution for it.

I don't think it's a bit issue for this sample to stay on Boot 2.7.8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.circleci.com/pipelines/github/lightbend/kalix-jvm-sdk/5467/workflows/d24e1efa-1af3-4e31-91c4-ddd7b9e64593/jobs/103012?invite=true#step-113-446

java.lang.NoClassDefFoundError: Could not initialize class com.github.tomakehurst.wiremock.jetty9.JettyHttpServerFactory
	at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27)

</dependency>
<dependency>
<groupId>io.kalix</groupId>
Expand Down