chore: update SpringBoot version in spring client sample #1425
Conversation
github-actions
bot
added
java-sdk-protobuf
kalix-runtime
| @@ -52,7 +52,7 @@ | |||
| <dependency> | |||
| <groupId>net.devh</groupId> | |||
| <artifactId>grpc-client-spring-boot-starter</artifactId> | |||
| <version>2.13.1.RELEASE</version> | |||
| <version>2.14.0.RELEASE</version> | |||
There was a problem hiding this comment.
This is another third party library to have grpc client. I'm just updating to last version.
Their README mention it is build with 2.6.13, https://github.com/yidongnan/grpc-spring-boot-starter#versions not clear if it will work with SpringBoot 3
There was a problem hiding this comment.
SpringBoot 3 uses Spring Framework 6 and may not be compatible with the grpc starter.
https://github.com/yidongnan/grpc-spring-boot-starter/issues/826
If that's the case, version 2.13.1 won't be a good fit either and we will have to keep this sample on SpringBoot 2.7.8
There was a problem hiding this comment.
Ok, tests failing with
java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27)
Caused by: java.lang.ClassNotFoundException: javax.servlet.DispatcherType
at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27We won't be able to update this sample for now. Unless grpc-spring-boot-starter gets updated or we have another solution for it.
I don't think it's a bit issue for this sample to stay on Boot 2.7.8.
There was a problem hiding this comment.
java.lang.NoClassDefFoundError: Could not initialize class com.github.tomakehurst.wiremock.jetty9.JettyHttpServerFactory
at com.example.client.spring.rest.CounterControllerIntegrationTest.setUp(CounterControllerIntegrationTest.java:27)
|
closing for now. Not so important for us to update this one or keep a broken PR open. |
No description provided.