Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make Travis use Node v11 (#1237) #1238

Merged
merged 1 commit into from
Apr 24, 2019
Merged

chore: make Travis use Node v11 (#1237) #1238

merged 1 commit into from
Apr 24, 2019

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Apr 24, 2019

Because node-sass is not compatible with the just-released v12, and is causing all CI runs to blow up; example:

https://travis-ci.org/liferay/alloy-editor/builds/523839150

Closes: #1237

Because node-sass is not compatible with the just-released v12, and is
causing all CI runs to blow up; example:

https://travis-ci.org/liferay/alloy-editor/builds/523839150

Closes: #1237
@wincent wincent requested a review from julien April 24, 2019 07:36
@wincent wincent changed the title chore: make Travis use Node v11 chore: make Travis use Node v11 (#1237) Apr 24, 2019
wincent added a commit that referenced this pull request Apr 24, 2019
We needed to force the use of v11 on the master branch (see #1238)
because v12 was causing CI builds to blow up. This is not a problem on
the 1.x branch because we were still using v8. But we should use the
same version on both branches for consistency.

Related: #1237
@julien julien merged commit 4e0d5fd into master Apr 24, 2019
@wincent wincent deleted the wincent/no-node-12 branch April 24, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run Travis builds with Node v12
2 participants