chore: make Travis use Node v11 (1.x) (#1237) #1239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just noticed that we have both a package-lock.json and a yarn.lock on this branch. - yarn.lock was added in 176cfd4 (Jan 2017) and only updated once, in c59af29 (also in Jan 2017). - package-lock.json was added in e636edf (Oct 2017) and updated on a number of occasions, the latest being in 2cb99ed (April 2019). Let's standardize on Yarn, to match what we're doing in the "master" branch and in other projects.
Because we need to move to a newer node-sass in order to build successfully with Node v11.
|
Ugh... dropping this as not worth the hassle. Old version of gulp with old version of gulp-sass, which means old version of node-sass. Tried to use "natives@1.1.3" (and "natives@1.1.6") to solve build issues, but build is horribly broken and would probably require a bunch of other updates to make it work. Will address the duplicate lock files in a separate pull. |
|
Superseded by: #1242 |
This was referenced Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to force the use of v11 on the master branch (see #1238) because v12 was causing CI builds to blow up. This is not a problem on the 1.x branch because we were still using v8. But we should use the same version on both branches for consistency.
Related: #1237