Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove simple::SimpleProtocol #3191

Merged
merged 7 commits into from Dec 9, 2022
Merged

feat!: Remove simple::SimpleProtocol #3191

merged 7 commits into from Dec 9, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Dec 2, 2022

Description

Due to lack of usage, remove the simple::SimpleProtocol. Users may look at libp2p::core::upgrade for alternatives.

Notes

Discovered through @umgefahren's master docs (#3126).

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Due to lack of usage, remove the `simple::SimpleProtocol`. Users may look at `libp2p::core::upgrade`
for alternatives.
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

@thomaseizinger what would be the right conventional commit prefix here?

Uhm, good question. This discussion discussion suggests refactor! or feat!. Personally I tend towards feat! because refactoring something shouldn't change the feature set.

@mxinden mxinden changed the title fix!: Remove simple::SimpleProtocol feat!: Remove simple::SimpleProtocol Dec 6, 2022
mxinden and others added 2 commits December 6, 2022 19:15
Co-authored-by: João Oliveira <hello@jxs.pt>
@mxinden
Copy link
Member Author

mxinden commented Dec 7, 2022

Testground failure is due to a rename:

failed to load composition file: failed to process composition template: open ping/_compositions/go-rust-interop-latest.toml: no such file or directory

libp2p/test-plans#70

See #2647 (comment) for libp2p-relay and libp2p-dcutr failures.

@thomaseizinger
Copy link
Contributor

Testground failure is due to a rename:

failed to load composition file: failed to process composition template: open ping/_compositions/go-rust-interop-latest.toml: no such file or directory

libp2p/test-plans#70

Fix is here: #3203

@mergify
Copy link

mergify bot commented Dec 9, 2022

This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏

@mxinden
Copy link
Member Author

mxinden commented Dec 9, 2022

For libp2p-dcutr and libp2p-relay failure, see #2647 (comment).

@mxinden mxinden merged commit 4fe518d into libp2p:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants