Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): avoid rate limits on GitHub API by supplying auth token #3199

Merged
merged 1 commit into from Dec 7, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Dec 6, 2022

Description

This follows the recommendation in the Usage section of the action: https://github.com/arduino/setup-protoc#usage
We won't need it once #3024 is landed but the failing CIs are annoying enough to warrant a temporary fix.

Example of a failing CI run: https://github.com/libp2p/rust-libp2p/actions/runs/3630150537/jobs/6123169342

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title feat(ci): install protoc via apt fix(ci): avoid rate limits on GitHub API by supplying auth token Dec 6, 2022
@thomaseizinger thomaseizinger marked this pull request as ready for review December 6, 2022 23:24
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden
Copy link
Member

mxinden commented Dec 7, 2022

Testground failure is due to a rename:

failed to load composition file: failed to process composition template: open ping/_compositions/go-rust-interop-latest.toml: no such file or directory

libp2p/test-plans#70

See #2647 (comment) for libp2p-relay and libp2p-dcutr failures.

@mxinden mxinden merged commit 4da6508 into master Dec 7, 2022
@mxinden
Copy link
Member

mxinden commented Dec 7, 2022

Not sure how successful this was. #3191 is now rate limited with an API key.

@thomaseizinger
Copy link
Contributor Author

Not sure how successful this was. #3191 is now rate limited with an API key.

Wow, so we replaced one error with another haha

@chunningham chunningham mentioned this pull request Feb 2, 2023
12 tasks
@thomaseizinger thomaseizinger deleted the fix/install-protoc-via-apt branch February 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants