Fix orphaned child process on Windows

[feryardiant]

Description

Quick fix while waiting upstream sindresorhus/execa#433 to be fixed, credit: FredKSchott/snowpack#1022

Motivation and Context

I came across the same issue as #2899, #2901 while I am learning to develop a monorepo using lerna. Means I'm not proficient enough about this stuff.

How Has This Been Tested?

It looks silly indeed, but there it is.

You could find the repo here, runs on:

OS Name:                   Microsoft Windows 10 Home Single Language
OS Version:                10.0.19043 N/A Build 19043
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
System Manufacturer:       ASUSTeK COMPUTER INC.
System Model:              UX303UB
Processor(s):              1 Processor(s) Installed.
                           [01]: Intel64 Family 6 Model 78 Stepping 3 GenuineIntel ~2492 Mhz

Types of changes

Honestly I'm not sure, but will investigate it further

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes. (sort of)
• All new and existing tests passed.

fixes #2899, #2901

[ghiscoding]

would that fix the issue #2841 I opened when v4 came out? I would assume, and hope, that the answer is probably yes!?

[abarke]

Maintainers 👋 please merge 🙏

[MoeKasp]

Dear Maintainers, please merge!

[abarke]

@evocateur could you please merge this as part of your next release!? That would be really great! Our teams relies heavily on Lerna and this small bug keeps popping up with many devs. We have reverted to lerna 3.22.1 that fixes the issue for now, but we would really like to keep up to date with Lerna releases.

[ghiscoding]

I can confirm that this PR fixes #2841 and I replicated this change in Lerna-Lite fork

[as-zlynn-philipps]

bump

[ghiscoding]

@as-zlynn-philipps sadly bumps aren't gonna help, Lerna is out of maintenance for well over a year now, see #3092. However this fix was applied in Lerna-Lite fork that I created, just in case you're interested.

[JamesHenry]

Thanks for this @feryardiant!

We can get this merged and released as part of next week's 5.1 release if you can fix up the unit tests and get CI to a passing/green state.

[JamesHenry]

@feryardiant unfortunately I do not have permission to push to your PR branch otherwise I would fix this for you.

All you need to do is apply the property to all the assertions in the spec file:

utils/npm-run-script/__tests__/npm-run-script.test.js

like so:

[JamesHenry]

Hi @feryardiant and everyone else, in order to ensure this made it into the 5.1 release (happening today), I went ahead and reproduced the change but included the necessary test updates per my note above.

I applied @feryardiant as the author so full credit remains.

Thanks all!

[feryardiant]

Thank you @JamesHenry