fix(command-dev): ensure no orphaned child process on Windows #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`execa` defaults to `windowsHide: true`, which prevents child processes from terminating child processes on exit [1]. Let's set `windowsHide: false` to terminate child processes properly on exit. [1]: sindresorhus/execa#433
|
Thanks a lot for looking into this @Xenonym. This is a rather tricky one. Both The Overall, I think using |
ehmicky
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #3251.
On Windows, the
devcommand does not properly terminate the framework process on exit, and leaves them running even thoughnetlify-clihas exited.This is because
execadefaults towindowsHide: true, which seems to interfere with terminating child processes: sindresorhus/execa#433.Other projects have also encountered this issue with execa's defaults and Windows: FredKSchott/snowpack#1022, lerna/lerna#2946.
Let's set
windowsHide: falseso that the framework process will terminate properly on exit.- Test plan
Run
netlify devwith this PR and attempt to exit on Windows (e.g. via Ctrl-C). No framework processes should be left running after exit.- A picture of a cute animal (not mandatory but encouraged)
馃