Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): properly update dependencies npm lockfile v2 #306

Merged
merged 1 commit into from Aug 10, 2022
Merged

fix(version): properly update dependencies npm lockfile v2 #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion __fixtures__/lockfile-leaf-v2/packages/package-1/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion __fixtures__/lockfile-leaf-v2/packages/package-1/package.json
View file
Open in desktop
Expand Up @@ -2,6 +2,10 @@
"name": "package-1",
"version": "1.0.0",
"dependencies": {
"tiny-tarball": "^1.0.0"
"tiny-tarball": "^1.0.0",
"package-2": "^1.0.0"
},
"devDependencies": {
"package-3": "2.0.0"
}
}
6 changes: 5 additions & 1 deletion packages/version/src/__tests__/update-lockfile-version.spec.ts
View file
Open in desktop
Expand Up @@ -44,14 +44,18 @@ describe('npm classic lock file', () => {
const [pkg] = await Project.getPackages(cwd);

pkg.version = '2.0.0';
pkg.dependencies['package-1'] = '^2.0.0';
pkg.devDependencies['package-2'] = '3.0.0';

const returnedLockfilePath = await updateClassicLockfileVersion(pkg as unknown as Package);

expect(returnedLockfilePath).toBe(path.join(pkg.location, 'package-lock.json'));
expect(Array.from((loadJsonFile as any).registry.keys())).toStrictEqual(['/packages/package-1']);
const updatedLockfile = fs.readJSONSync(returnedLockfilePath as string);
expect(updatedLockfile).toHaveProperty('version', '2.0.0');
expect(updatedLockfile).toHaveProperty(['packages', '', 'version'], '2.0.0');
expect(updatedLockfile).toHaveProperty(['packages', '', 'dependencies', 'package-1'], '^2.0.0');
expect(updatedLockfile).toHaveProperty(['packages', '', 'dependencies', 'tiny-tarball'], '^1.0.0');
expect(updatedLockfile).toHaveProperty(['packages', '', 'devDependencies', 'package-2'], '3.0.0');
});

test('updateClassicLockfileVersion without sibling lockfile', async () => {
Expand Down
6 changes: 6 additions & 0 deletions packages/version/src/lib/update-lockfile-version.ts
View file
Open in desktop
Expand Up @@ -45,6 +45,12 @@ export async function updateClassicLockfileVersion(pkg: Package): Promise<string
// update version for a npm lockfile v2 format
if (pkgLockFileObj.packages?.['']) {
pkgLockFileObj.packages[''].version = pkg.version;
if (pkgLockFileObj.packages[''].dependencies) {
pkgLockFileObj.packages[''].dependencies = pkg.dependencies;
}
if (pkgLockFileObj.packages[''].devDependencies) {
pkgLockFileObj.packages[''].devDependencies = pkg.devDependencies;
}
}

await writeJsonFile(lockFilePath, pkgLockFileObj, {
Expand Down