Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): add double quotes around script target containing colon #246

Merged
merged 1 commit into from Jul 6, 2022

Conversation

ghiscoding
Copy link
Member

Description

Adds double-quotes around script target when running with Nx (for example "dev:build": "tsc build")

Motivation and Context

follows bug fix pushed in original Lerna PR 3218

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #246 (18da175) into main (34a2574) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   93.78%   93.78%   +0.01%     
==========================================
  Files         142      142              
  Lines        4080     4082       +2     
  Branches      828      829       +1     
==========================================
+ Hits         3826     3828       +2     
  Misses        254      254              
Impacted Files Coverage Δ
packages/run/src/run-command.ts 95.33% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a2574...18da175. Read the comment docs.

@ghiscoding ghiscoding merged commit 50d7547 into main Jul 6, 2022
@ghiscoding ghiscoding deleted the bugfix/nx-run-escape-quotes-script-with-colon branch July 6, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant