Merge pull request #246 from ghiscoding/bugfix/nx-run-escape-quotes-s…

…cript-with-colon

fix(run): add double quotes around script target containing colon

packages/run/package.json

@@ -43,6 +43,8 @@
   "devDependencies": {
     "@types/execa": "^2.0.0",
     "@types/p-map": "^2.0.0",
+    "globby": "^11.1.0",
+    "jest-circus": "^28.1.2",
     "perf_hooks": "^0.0.1",
     "yargs-parser": "^21.0.1"
   }

packages/run/src/__fixtures__/powered-by-nx/packages/package-1/package.json

@@ -3,6 +3,7 @@
   "version": "1.0.0",
   "scripts": {
     "fail": "exit 1",
-    "my-script": "echo package-1"
+    "my-script": "echo package-1",
+    "another-script:but-with-colons": "echo package-1-script-with-colons"
   }
 }

packages/run/src/__tests__/run-command.spec.ts

@@ -383,6 +383,13 @@ describe('RunCommand', () => {
       expect(collectedOutput).toContain('Successfully ran target');
     });
 
+    it('runs a script with a colon in the script name', async () => {
+      collectedOutput = '';
+      await lernaRun(testDir)('another-script:but-with-colons');
+      expect(collectedOutput).toContain('package-1-script-with-colons');
+      expect(collectedOutput).toContain('Successfully ran target');
+    });
+
     it('runs a script only in scoped packages', async () => {
       collectedOutput = '';
       await lernaRun(testDir)('my-script', '--scope', 'package-1');

packages/run/src/run-command.ts

@@ -205,6 +205,11 @@ export class RunCommand extends Command<RunCommandOption & FilterOptions> {
     return chain;
   }
 
+  /** Nx requires quotes around script names of the form script:name*/
+  escapeScriptNameQuotes(scriptName: string) {
+    return scriptName.includes(':') ? `"${scriptName}"` : scriptName;
+  }
+
   async runScriptsUsingNx() {
     if (this.options.ci) {
       process.env.CI = 'true';
@@ -214,7 +219,8 @@ export class RunCommand extends Command<RunCommandOption & FilterOptions> {
     const { targetDependencies, options } = await this.prepNxOptions();
     if (this.packagesWithScript.length === 1) {
       const { runOne } = await import('nx/src/command-line/run-one');
-      const fullQualifiedTarget = this.packagesWithScript.map((p) => p.name)[0] + ':' + this.script;
+      const fullQualifiedTarget =
+        this.packagesWithScript.map((p) => p.name)[0] + ':' + this.escapeScriptNameQuotes(this.script);
       return (runOne as any)(
         process.cwd(),
         {