Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly configure nginx proxy settings #4564

Merged
merged 1 commit into from
May 16, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented May 15, 2024

Summary

Description of the change(s) you made

  • Explicitly sets a few proxy settings to eliminate nginx configuration as a possible source of Studio 502 issues proxying to GCS
  • Removes catalog server configuration

Manual verification steps performed

None

References

https://learningequality.slack.com/archives/C0WHZ9FPX/p1715724564260899

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@DXCanas DXCanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what most of these props mean, but I figure it's worth a shot on hotfixes.

Let's see if @aronasorman get a chance to review, and merge by tomorrow the 16th either way?

@aronasorman
Copy link
Collaborator

Hmm I thought we had nginx tests I wrote at one poInt -- do they not run anymore?

@bjester
Copy link
Member Author

bjester commented May 15, 2024

@aronasorman We do, thanks to you! but not in the hotfixes branch yet 😅 we got a bunch of stuff in the pipeline that needs merged up, including those CI checks

@rtibbles rtibbles merged commit 6dffc0b into learningequality:hotfixes May 16, 2024
9 checks passed
@bjester bjester mentioned this pull request May 16, 2024
24 tasks
@akolson akolson mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants