Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v2024.06.04 #4518

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Release v2024.06.04 #4518

wants to merge 61 commits into from

Conversation

akolson
Copy link
Member

@akolson akolson commented Apr 17, 2024 •
edited

Summary

This is a major rebranding release for Studio. It also includes a few bug fixes and enhancements.

Enhancements

  • The UI has been rebranded with the new Learning Equality theme colors
  • The collection of channels related to COVID information is no longer pinned to the top of Content Library.

Bug fixes

  • The misalignment of the copy failure retry action has been fixed
  • Import search filters have been fixed.
  • A user can now copy a resource into a clipboard when importing from other channels
  • When editing a channel, a user is now able to upload content and preview it correctly.
PR Issues Category QA Focus
#4319 #4272 Bug fix N/A
#4376 #4089 Bug fix Using filters in import search
#4454 N/A Enhancement Critical workflows
#4459 #4439 Enhancement Critical workflows
#4520 N/A Enhancement Studio welcome email
#4522 #4519 Enhancement Account creation
#4531 #4529 Enhancement Deleting a Studio account
#4530 #4508 Bug fix Import from other channels
#4523 #4521 Enhancement LE logo usages
#4539 N/A Enhancement Critical workflows
#4546 N/A Enhancement Favicons (tab icons)
#4549 #4547 Enhancement Cards hover styling
#4564 N/A Bug fix Channel edit: upload and preview a file
#4568 N/A Bug fix Channel edit: upload and preview a file
#4574 N/A Enhancement Channel list cards
#4581 N/A Enhancement Studio Content Library

KshitijThareja and others added 30 commits October 30, 2023 23:53
@KshitijThareja
Fix misalignment of copy failure retry
6fe058f
@KshitijThareja
Change alignment of retry button
e71e478
@bjester
Merge pull request #4319 from KshitijThareja/4272
b3b43ac 
Fix misalignment of copy failure retry CTA
@FidalMathew
[fix] Import applied language filter
052b5a9
@FidalMathew
add languageFilter event
d16b50b
@FidalMathew
fix naming
30ca0af
@FidalMathew
fix languages bug
a506b79
@vkWeb
Minor logic refactor
f5d6319
@vkWeb
Merge pull request #4376 from FidalMathew/my-hotfixes
4dde334 
[fix] Import applied language filter
@MisRob @bjester
Upgrade Studio to KDS 3.0.0 (2/3)
ce82a4c 
Fixes "Error: Can't resolve 'kolibri-design-system/lib/utils/i18n'"
caused by removal of this file in KDS v2.0.0 by copying the removed
file content directly to Studio.
@MisRob @bjester
Upgrade Studio to KDS 3.0.0 (3/3)
950565f 
Remove deprecated `value` prop in favor of the new
`buttonValue` prop that's supposed to replace it
in `KRadioButton`.
@bjester
Finalize upgrade to v3+ of KDS
4d0ac3b
@akolson
Updates grey shade usages
cccd0d8
@akolson
AppBar color upgrade
eeabbf6
@rtibbles @akolson
Cherry-picks theming base work
7b562e7
@akolson
updates yarn.lock
ef04e91
@akolson
implements further rebrand changes
2823d9d
@akolson
Removes console log
4b894b3
@marcellamaki
Merge pull request #4454 from bjester/hotfixes-kds
6cf31f8 
Upgrade KDS to v3 in hotfixes branch
@akolson
Updates studio to use KDS library
bd033b1
@akolson
changes immersive bar color to black
fad5f46
@akolson
Updates colors
51da497
@akolson
Updates KLogo
15c3511
@akolson
Updates logo usages to guidelines
02484aa
@akolson
Updates logo usages to guidelines
0cb9338
@akolson
Updates KDS version + warning icon color
5b686cf
@akolson
Updates warning icon color
dc3a7cb
@akolson
Fixes incorrect coach content icon color
a3cf778
@bjester
Merge pull request #4459 from akolson/studio_rebranding
f0fa1f6 
Studio: Audit and fix theme token updates against KDS
@akolson
Merge branch 'master' into hotfixes
82e8578
@bjester
Merge pull request #4546 from rtibbles/new_favicon
defee15 
Update favicon to have no background.
@akolson akolson changed the title Rebranding patch release Release v2024.05.02 May 1, 2024
@akolson akolson changed the title Release v2024.05.02 Release v2024.05.24 May 23, 2024
@akolson
Copy link
Member Author

akolson commented May 28, 2024

HI @radinamatic @pcenov. The PR has been updated with the latest changes. Thanks

@akolson akolson marked this pull request as ready for review May 28, 2024 17:34
@radinamatic
Copy link
Member

Three issues were found on latest testing, last one not necessarily a blocker:

#4579
#4578
#4577

@bjester
Copy link
Member

bjester commented May 30, 2024

Three issues were found on latest testing, last one not necessarily a blocker:

#4579 #4578 #4577

The first 2 issues should no longer be extant. They were caused by testing direct proxying to the cloud bucket through Cloudflare. Apologies that this disrupted QA

pcenov
pcenov previously approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjester - I confirm that both #4579
and #4578 are fixed now and there are no newly discovered issues.

@akolson
Copy link
Member Author

akolson commented Jun 4, 2024

Hi @radinamatic @pcenov. PR has been updated with more changes. Please see issue table. Thanks

@akolson akolson changed the title Release v2024.05.24 Release v2024.06.04 Jun 4, 2024
@pcenov
Copy link
Member

pcenov commented Jun 5, 2024

Hi @radinamatic I've tested #4581 and I confirm that there are no issues caused by the removal of the COVID card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcenov pcenov pcenov left review comments

@bjester bjester Awaiting requested review from bjester

@radinamatic radinamatic Awaiting requested review from radinamatic

At least 2 approving reviews are required to merge this pull request.

Assignees

@bjester bjester

@akolson akolson

Labels
None yet
Projects
None yet
Milestone
Studio: rebranding patch
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@akolson @pcenov @radinamatic @bjester @KshitijThareja @FidalMathew @vkWeb @MisRob @rtibbles @marcellamaki