Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set vue to a beta version for testing #4065

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Jul 23, 2018

Summary

I had observed that computed props were not working as expected, and were not caching intermediary values. It appears that this is addressed in a recent risky upgrade to Vue

This PR upgrades to the beta so we can test it in develop for a while and watch out for issues. It also re-introduces some behaviors that were slow in the old code

Reviewer guidance

just sanity check that things work

References

https://github.com/vuejs/vue/releases/tag/v2.5.17-beta.0

Before 0.11.0 is released we need to upgrade to 2.5.17 final - see #4075


Contributor Checklist

  • Contributor has fully tested the PR manually
  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If there are any front-end changes, before/after screenshots are included
  • If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

add back in previously slow code
@indirectlylit indirectlylit added this to the 0.11.0 milestone Jul 23, 2018
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #4065 into develop will increase coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4065      +/-   ##
===========================================
+ Coverage    50.19%   50.19%   +<.01%     
===========================================
  Files          634      634              
  Lines        21014    21013       -1     
  Branches      2714     2714              
===========================================
+ Hits         10547    10548       +1     
  Misses        9796     9796              
+ Partials       671      669       -2
Impacted Files Coverage Δ
...olibri/core/assets/src/mixins/responsive-window.js 90% <62.5%> (+5.68%) ⬆️
...ts/src/views/ManageContentPage/ChannelListItem.vue 95.55% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c4cd8...355acf3. Read the comment docs.

@christianmemije christianmemije merged commit 63276e9 into learningequality:develop Jul 26, 2018
@indirectlylit indirectlylit removed the TODO: needs review Waiting for review label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants