Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set Vue to 2.5.17 and use watcher-based optimizations on responsive window mixin #4075

Closed
indirectlylit opened this issue Jul 26, 2018 · 6 comments
Assignees
Labels
P0 - critical Priority: Release blocker or regression
Milestone

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Jul 26, 2018

In #4065 we're setting vue to a beta version for testing. It's very important that we upgrade vue to 2.5.17 final before release 0.11.0

check version on npm page

@indirectlylit indirectlylit added the P0 - critical Priority: Release blocker or regression label Jul 26, 2018
@indirectlylit indirectlylit added this to the 0.11.0 milestone Jul 26, 2018
@indirectlylit indirectlylit changed the title upgrade view to 2.5.17 final; upgrade view to 2.5.17 final Jul 26, 2018
@jonboiser jonboiser changed the title upgrade view to 2.5.17 final upgrade Vue to 2.5.17 final Jul 31, 2018
@jonboiser jonboiser self-assigned this Aug 2, 2018
jonboiser added a commit to jonboiser/kolibri that referenced this issue Aug 2, 2018
@indirectlylit
Copy link
Contributor Author

According to the releases page, 2.5.17:

is a hot fix that ... does NOT include any changes from 2.5.17-beta.0

Looks like they had an emergency security fix, and those beta changes will come in 2.5.18?

@indirectlylit indirectlylit reopened this Aug 16, 2018
@indirectlylit indirectlylit changed the title upgrade Vue to 2.5.17 final upgrade Vue to 2.5.18 final Aug 16, 2018
@indirectlylit
Copy link
Contributor Author

indirectlylit commented Aug 16, 2018

also, by committing 34edbc4 we are no longer testing the beta

@jonboiser jonboiser removed their assignment Aug 29, 2018
@DXCanas
Copy link
Member

DXCanas commented Sep 25, 2018

A little confused by this issue @indirectlylit, as 2.5.18 still hasn't been released?

@indirectlylit indirectlylit self-assigned this Sep 27, 2018
@indirectlylit
Copy link
Contributor Author

Darn. I'd hoped it would have been released by now.

I upgraded because we need the performance improvements in vuejs/vue#7824

Unfortunately that change caused a regression: vuejs/vue#8446

I'll need to make a performance update to work around this

@DXCanas
Copy link
Member

DXCanas commented Sep 27, 2018

@devon Is there a specific component that was causing issues?

@indirectlylit
Copy link
Contributor Author

Yes it was an optimization in the responsive window mixin, where the computed props were being re-calculated constantly during resizes rather than just at breakpoint thresholds.

I think we'll basically need to revert this commit: 355acf3

@indirectlylit indirectlylit changed the title upgrade Vue to 2.5.18 final set Vue to 2.5.17 and use watcher-based optimizations on responsive window mixin Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

3 participants