Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Prettier and fix ESLint complaints #28

Merged
merged 5 commits into from Dec 5, 2021
Merged

Run Prettier and fix ESLint complaints #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
752d7ce
Apply ESLint & Prettier on `src/`
alexnguyenn Dec 4, 2021
e47e998
Fix more ESLint complaints
alexnguyenn Dec 5, 2021
1e9dd6f
No error on unmatched pattern
gwwatkin Dec 5, 2021
dc814c9
Fix null assertion warnings
gwwatkin Dec 5, 2021
69e86fe
Remove ts-ignore directive
gwwatkin Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.json
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@
],
"rules": {
"react/react-in-jsx-scope": "off",
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/ban-ts-comment": "off"
"@typescript-eslint/no-inferrable-types": "off"
}
}
4 changes: 2 additions & 2 deletions src/pages/BaseTemplate.tsx
View file
Open in desktop
Expand Up @@ -9,8 +9,8 @@ import UploadCircuitPage from "./UploadCircuitPage"
import { AppState } from "../appState"

const anchor_position_shift = (window: Window) => {
// @ts-ignore
if ($(window).width() > 991) {
const windowWidth = $(window).width() ?? 1000 // Default width
if (windowWidth > 991) {
Comment on lines +12 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keelando any idea if .width() can ever return null?

const anchor_elements = $(".anchor-mob")
anchor_elements.toggleClass("anchor-mob anchor-pc")
} else {
Expand Down