Run Prettier and fix ESLint complaints

[alexnguyenn]

As title

[alexnguyenn]

@gwwatkin I turned off @typescript-eslint/ban-ts-comment which interferes with @ts-ignore comment in BaseTemplate.tsx. If you know how to fix it feel free to do so.

Also here are the last warnings I am having for LatticeView.tsx:

157:35  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
157:35  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
163:34  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
163:34  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion

Since they are warnings they won't fail any CI we setup later on, but if you can fix it go ahead.

[gwwatkin]

Get this error running npm run lint:fix:

> ls-ui-react-app@0.1.0 lint:fix
> eslint --fix src/**/*.{js,jsx,ts,tsx}


Oops! Something went wrong! :(

ESLint: 7.32.0

No files matching the pattern "src/**/*.js" were found.
Please check for typing mistakes in the pattern.

Which is strange because, npx eslint --fix src/**/*.{js,jsx,ts,tsx} runs as expected

[gwwatkin]

Ok found the problem the npx eslint --fix ./src/**/*.{js,jsx,ts,tsx} also doesn't work, its npx eslint --fix ./src/**/*.{ts,tsx} that works

[gwwatkin]

Tried this: import-js/eslint-plugin-import#1645 (comment)
also doesn't work

[gwwatkin]

This is the only thing that fixes it, though it excludes js and jsx files from liniting

diff --git a/package.json b/package.json
index 2828b95..8353fac 100644
--- a/package.json
+++ b/package.json
@@ -34,8 +34,8 @@
     "build": "react-scripts build",
     "test": "react-scripts test",
     "eject": "react-scripts eject",
-    "lint": "eslint src/**/*.{js,jsx,ts,tsx}",
-    "lint:fix": "eslint --fix src/**/*.{js,jsx,ts,tsx}"
+    "lint": "eslint src/**/*.{ts,tsx}",
+    "lint:fix": "eslint --fix src/**/*.{ts,tsx}"
   },
   "browserslist": {
     "production": [

[gwwatkin]

Not that it's a big problem to excluding js and jsx from linting, but it would be nice to combine it with something that forbids js and jsx. Tried the "allowJs": false, option in tsconfig.json but it also forbids importing js which is going to be a problem with modules like JQuery.

Also if we do end up adding some plain js we can always just re enable the option.

[gwwatkin]

Ok it turns out I could just add this option here, sorry for the noise in the PR

[alexnguyenn]

no problem, nice to see that we have a fix for this.

[gwwatkin]

Added some fixes

• --no-error-on-unmatched-pattern
• null assertion warnings
• removed the ts-ignore directive

[gwwatkin]

@Keelando any idea if .width() can ever return null?