[8.x] Bumped minimum Symfony version #35535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jason Varga <jason@pixelfear.com>
GrahamCampbell
changed the title
jasonvarga
added a commit
to statamic/cms
that referenced
this pull request
Dec 8, 2020
laravel/framework#35535 Might be better to bump the Laravel 8 min requirement, but our test matrix overwrites it and I don't really want to mess with that just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony version 5.1.3 and below are very broken on PHP 8. Nobody would want to use them, so we need not support them. Moreover, dropping them means we can add tests that don't work on the old broken versions (such as the test added in this PR for the empty string conversion middleware).