Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] Bumped minimum Symfony version (#35535)
* Bumped minimum symfony version * Added test for converting empty strings middleware Co-Authored-By: Jason Varga <jason@pixelfear.com> Co-authored-by: Jason Varga <jason@pixelfear.com>
- Loading branch information
1 parent
b08aef6
commit c2337b6
Showing
14 changed files
with
63 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
tests/Foundation/Http/Middleware/ConvertEmptyStringsToNullTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Tests\Foundation\Http\Middleware; | ||
|
|
||
| use Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull; | ||
| use Illuminate\Http\Request; | ||
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\HttpFoundation\Request as SymfonyRequest; | ||
|
|
||
| class ConvertEmptyStringsToNullTest extends TestCase | ||
| { | ||
| public function testConvertsEmptyStringsToNull() | ||
| { | ||
| $middleware = new ConvertEmptyStringsToNull(); | ||
| $symfonyRequest = new SymfonyRequest([ | ||
| 'foo' => 'bar', | ||
| 'baz' => '', | ||
| ]); | ||
| $symfonyRequest->server->set('REQUEST_METHOD', 'GET'); | ||
| $request = Request::createFromBase($symfonyRequest); | ||
|
|
||
| $middleware->handle($request, function (Request $request) { | ||
| $this->assertSame('bar', $request->get('foo')); | ||
| $this->assertNull($request->get('bar')); | ||
| }); | ||
| } | ||
| } |