Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Don't overwrite minute and hour when specifying a time with twiceMonthly() #35436

Merged
merged 3 commits into from Dec 1, 2020
Merged

[8.x] Don't overwrite minute and hour when specifying a time with twiceMonthly() #35436

merged 3 commits into from Dec 1, 2020

Conversation

JayBizzle
Copy link
Contributor

Fixes #35429

@JayBizzle JayBizzle mentioned this pull request Dec 1, 2020
Closed
@taylorotwell taylorotwell merged commit 24636f0 into laravel:8.x Dec 1, 2020
@JayBizzle JayBizzle changed the title Don't overwrite minute and hour when specifying as time with twiceMonthly() Don't overwrite minute and hour when specifying a time with twiceMonthly() Dec 1, 2020
@GrahamCampbell
Copy link
Member

Is this bug present in 6.x?

@GrahamCampbell GrahamCampbell changed the title Don't overwrite minute and hour when specifying a time with twiceMonthly() [8.x] Don't overwrite minute and hour when specifying a time with twiceMonthly() Dec 1, 2020
@driesvints
Copy link
Member

@GrahamCampbell it seems it is. @JayBizzle can you send this to 6.x as well?

@JayBizzle
Copy link
Contributor Author

Will do this evening unless someone beats me to it 👍🏻

@JayBizzle JayBizzle deleted the patch-1 branch December 1, 2020 19:44
@JayBizzle
Copy link
Contributor Author

JayBizzle commented Dec 1, 2020 •
edited

@driesvints This bug is not present on the 6.x branch. The extra $time parameter for the twiceMonthly() method was added in 7.x

See here #33274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console schedule twiceMonthly at a given time
4 participants
@JayBizzle @GrahamCampbell @driesvints @taylorotwell