Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console schedule twiceMonthly at a given time #35429

Closed
brightjune opened this issue Dec 1, 2020 · 2 comments · Fixed by #35436
Closed

Console schedule twiceMonthly at a given time #35429

brightjune opened this issue Dec 1, 2020 · 2 comments · Fixed by #35436

Comments

@brightjune
Copy link

brightjune commented Dec 1, 2020

  • Laravel Version: 8.x
  • PHP Version: 7.4
  • Database Driver & Version: MySQL

Description:

twiceMonthly at a given time is not working ok

image

dailyAt($time) is set the minute and hour, then in function return set minute and hour to 0 again.

Steps To Reproduce:

$schedule->command('test:test')
                ->twiceMonthly(1, 16, '1:30');

Fixed:

public function twiceMonthly($first = 1, $second = 16, $time = '0:0')
    {
        $daysOfMonth = $first.','.$second;

        $this->dailyAt($time);

        return $this->spliceIntoPosition(3, $daysOfMonth);
    }
@driesvints
Copy link
Member

We'll need a little more info at why it's not working okay.

@JayBizzle
Copy link
Contributor

Created a PR that displays this issue #35436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants