[7.x] Allow setting synchronous_commit for Postgres #33897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.postgresql.org/docs/current/runtime-config-wal.html#GUC-SYNCHRONOUS-COMMIT > Specifies whether transaction commit will wait for WAL records to be written to disk before the command returns a “success” indication to the client. Valid values are on, remote_apply, remote_write, local, and off > … > So, turning synchronous_commit off can be a useful alternative when performance is more important than exact certainty about the durability of a transaction.
mfn
force-pushed
the
mfn-pgsql-sync-commit
branch
from
742f4a8
to
53aea3d
Compare
mfn
added a commit
to mfn/laravel
that referenced
this pull request
Aug 15, 2020
It's deliberately not enabled but provided commented out so developers can easily discover that the setting is available. The default `on` is _probably_ safe (Postgres default), but a server might have a different default value and blindly setting it to `on` may cause problems. Connected to laravel/framework#33897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.postgresql.org/docs/current/runtime-config-wal.html#GUC-SYNCHRONOUS-COMMIT
My use-case is exact the last paragraph, so I can turn it
off.PR for showing the setting in the config => laravel/laravel#5375