[2.x] Laravel 10 support

[antonioribeiro]

Just installed it locally, tests are passing.

[what-the-diff]

• Add support for Laravel 10
• Fix date casting in models
• Update composer dependencies to latest versions (including PHP 8) and add new ones: chillerlan/php-qrcode, friendsofphp/php-cs-fixer, kalnoy/nestedset, nunomaduro/collision and orchestra/testbench v8.*
• Remove unused code from PasswordsTest::testCanExpireResetPasswordToken() test case as it's not needed anymore since the password reset notification was updated with a custom subject line that includes the token itself so we can assert on its presence instead of asserting on an error message which is no longer present anyway due to this change https://github.com/laravelio/laravel.io_v2_sourcecode_publication1stphase2020augustoctoberreleasecycleplanninganddevelopmentworkflowprocessesdocumentationguidelinesbestpracticesrecommendationsetc./commitdiff?parent=c9b7d6a0e&target=5dbddffcc

[ifox]

Thanks @antonioribeiro!

Some of our dependencies are not supporting Laravel 10 yet, as noted on #2122 (comment).

lazychaser/laravel-nestedset is an optional dependency, so not a blocker, but cartalyst/tags and Astronomic/laravel-translatable would prevent the install at the moment, no?

[antonioribeiro]

Yeah, you are right, @ifox , closing this for now.

[ifox]

I think we can keep it open? Definitely want to release support for Laravel 10 on Twill 2.

[antonioribeiro]

Sure I'll reopen it as soon as we are able to close all subjects. I'm waiting on the nestedset guys to merge one of those PRs :D

[antonioribeiro]

@ifox , all PHPUnit tests are now passing, but we have some flags on roave-backwards-compatibility-check that must be thought before we move forward. This is one example:

protected $dates = [
    'deleted_at',
];

It was deprecated in favor of $casts on Laravel 8, and now removed from Laravel 10, so we are supposed to change the implementation but should we keep supporting Laravel versions that doesn't have $casts, are we still supporting any?

[ifox]

Thanks @antonioribeiro.

We do indeed have to take a closer look at this change, because we also rely on getDates from Eloquent, which implementation has changed in Laravel 10: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1441. Before, it was using the $dates model property: https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1450. And this is where we rely on it:

twill/src/Repositories/Behaviors/HandleDates.php

Line 17 in 748467b

foreach ($this->model->getDates() as $f) {

We are not supporting any version that didn't have $casts, as it has been available since 5.0.

[antonioribeiro]

@ifox, I just reimplemented getDates() to support Laravel 10 getting from $dates and created some tests to check if it's all working fine.

Most of the other errors can probably be ignored, but I will still look at them all tomorrow

[antonioribeiro]

@ifox , here's the analysis of the breaking change errors we get:

BROKEN - Needs a fix -- Please review the fix

Error: Property Illuminate\Database\Eloquent\Model#$dates was removed

Can probably be ignored

Error: Default parameter value for parameter $inverse of Illuminate\Database\Eloquent\Concerns\HasRelationships#morphToMany() changed from false to NULL

Error: Parameter 7 of Illuminate\Database\Eloquent\Concerns\HasRelationships#morphToMany() changed name from inverse to relation

Not being used directly (internal calls)

Error: Method Illuminate\Foundation\Bus\Dispatchable::dispatchNow() was removed

Error: Method Illuminate\Foundation\Bus\DispatchesJobs#dispatchNow() was removed

Error: Parameter 4 of Illuminate\Foundation\Validation\ValidatesRequests#validateWithBag() changed name from customAttributes to attributes

Error: The parameter $parameters of Illuminate\Support\Traits\Macroable#__call() changed from no type to a non-contravariant array

Error: The parameter $parameters of Illuminate\Support\Traits\Macroable#__call() changed from no type to array

Error: Parameter 3 of Illuminate\Foundation\Validation\ValidatesRequests#validate() changed name from customAttributes to attributes

[what-the-diff]

PR Summary

• Add Laravel 10 Support
  Updated the codebase to support Laravel 10
• Fix Date Casting in Models
  Improved the handling of date formats in models
• Update Composer Dependencies
  Upgraded dependencies to the latest version, including PHP 8, and added new ones: chillerlan/php-qrcode, friendsofphp/php-cs-fixer, kalnoy/nestedset, nunomaduro/collision, and orchestra/testbench v8.*
• Remove Unused Code from Tests Folder
  Removed unnecessary code in the tests folder to resolve errors with PHPUnit 9+

[what-the-diff]

PR Summary

• Add Support for Laravel 10
  This update adds compatibility with Laravel 10, a popular PHP framework.

• Fix Date Casting in Models
  The fix improves the handling of date fields in the application's data models, providing accurate results.

• Update Composer Dependencies
  Dependencies, including PHP 8, are updated to their latest versions, enhancing the application's performance and security.

• Remove Unnecessary CI Checker
  The backwards compatibility checker is removed from the Continuous Integration (CI) process, as it's no longer required due to an updated laravel/framework dependency version.