Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Replace deprecated phpunit <7.5.0 methods #26976

Closed

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Dec 28, 2018

replace deprecated phpunit methods with new ones

see this link :

sebastianbergmann/phpunit#3368

Note that the composer.json file now requires phpunit 7.5 or more

image

@imanghafoori1 imanghafoori1 changed the title replace deprecated phpunit methods [5.8] replace deprecated phpunit methods Dec 28, 2018
@imanghafoori1
Copy link
Contributor Author

This tests fail in the env:lowest config.
because in that case phpunit version is 7.0.0

@imanghafoori1 imanghafoori1 changed the title [5.8] replace deprecated phpunit methods [5.8] Replace deprecated phpunit 7.5.0 methods Dec 28, 2018
@devcircus
Copy link
Contributor

Is there anything stopping us from bumping the minimum requirement for phpunit in 5.8 to 7.5?

@imanghafoori1
Copy link
Contributor Author

imanghafoori1 commented Dec 28, 2018

I do not know
I reopen the issue so that the members can decide on that.
It should be bumped up from ^7.0 to ^7.5
It does not seem to be problematic.

@imanghafoori1 imanghafoori1 reopened this Dec 28, 2018
@imanghafoori1 imanghafoori1 changed the title [5.8] Replace deprecated phpunit 7.5.0 methods [5.8] Replace deprecated phpunit <7.5.0 methods Dec 28, 2018
@GrahamCampbell
Copy link
Member

Please send this to the 5.7 branch, since all these changes only affect the tests, so we can safely bumb the minimum version of phpunit, without it being a breaking change, since it is with respect to testing the framework itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants