Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] PHPunit bugs and best practices false positive assertion suggestion #1152

Closed
vladyslavstartsev opened this issue Dec 30, 2018 · 2 comments
Closed

[Bug] PHPunit bugs and best practices false positive assertion suggestion #1152

vladyslavstartsev opened this issue Dec 30, 2018 · 2 comments
Assignees
@kalessil
Labels
bug / false-positive fixed
Milestone
C-4.0.4

Comments

@vladyslavstartsev
Copy link
Contributor

vladyslavstartsev commented Dec 30, 2018 •
edited

Subject Details
Issue type Bug/False-Positive, Feature request, Support Request
Plugin Php Inspections (EA Extended), v3.0.9.1
Language level PHP 7.2

Current behaviour (description/screenshot:)

this

$this->assertTrue(is_array($this->manager->driver('sqlite')));

suggest to be converted to this

$this->assertInternalType('array', $this->manager->driver('sqlite'));

Expected behaviour

It should not be suggested to do that because since phpunit 7.4 (not sure about the version) assertInternalType is deprecated

see sebastianbergmann/phpunit#3369
also see as an example laravel/framework#26976 for changes made
@vladyslavstartsev vladyslavstartsev changed the title [Bug] PHPunit [Bug] PHPunit bugs and best practices false positive assertion suggestion Dec 30, 2018
@kalessil kalessil self-assigned this Jan 2, 2019
@kalessil kalessil added this to the C-3.0.11 milestone Jan 2, 2019
@kalessil kalessil modified the milestones: C-3.0.11, C-3.0.13 Mar 25, 2019
@kalessil kalessil modified the milestones: C-3.0.13, C-3.0.14 Apr 9, 2019
@kalessil kalessil modified the milestones: C-3.0.14, C-3.0.15 Aug 5, 2019
@kalessil kalessil modified the milestones: C-3.0.15, C-3.0.16 Sep 4, 2019
@kalessil kalessil modified the milestones: C-3.0.16, C-3.0.17 Sep 24, 2019
@kalessil kalessil modified the milestones: C-3.0.17, C-4.0.2 Nov 25, 2019
@fruitl00p
Copy link

@kalessil this might be related to #1155

@kalessil kalessil modified the milestones: C-4.0.2, C-4.0.3 Jan 7, 2020
@kalessil kalessil mentioned this issue Apr 26, 2020
Closed
@kalessil kalessil modified the milestones: C-4.0.3, C-4.0.4 Apr 26, 2020
kalessil added a commit that referenced this issue Apr 26, 2020
@kalessil
[#1152] PhpUnitTestsInspector: assertInternalType - respect PhpUnit v…
668c9dd 
…ersion (via settings)
@kalessil
Copy link
Owner

Fixed!

kalessil added a commit that referenced this issue Apr 26, 2020
@kalessil
[#1152] PhpUnitTestsInspector: fixed broken build
59b06ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalessil kalessil

Labels
bug / false-positive fixed
Projects
None yet
Milestone
C-4.0.4
Development

No branches or pull requests
3 participants
@fruitl00p @kalessil @vladyslavstartsev