Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to run on active Node versions #3327

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

jnoordsij
Copy link
Contributor

Node v12 and v17 have reached EOL; Node v19 has been released.

Note: it might be desirable to also update the required Node.js version in package.json in a future version.

@jnoordsij
Copy link
Contributor Author

Any chance of getting this and #3328 in anytime soon? Or has this project basically gone completely stale due to the release of Laravel Vite?

@thecrypticace
Copy link
Collaborator

Hey, sorry! Life and work generally has had me focused on other stuff. This looks good. I would say if you can you should update to Laravel Vite because the DX is imo significantly better (and much faster). But definitely recognize the need for Mix still exists. I need to dedicate some time to Mix again over the weekends.

@thecrypticace thecrypticace merged commit b116bf0 into laravel-mix:master Feb 21, 2023
@jnoordsij
Copy link
Contributor Author

Thanks for your response! No worries here, I totally understand this project is not a main priority anymore.

I do definitely intend to migrate at some point, but still looking to find some spare time for it and also waiting for some Vite plugins (like https://github.com/ckeditor/vite-plugin-ckeditor5/) to become slightly more stable. It's great to still have this maintained as a stable backup in the meantime ;)

@jnoordsij jnoordsij deleted the update-node-test-versions branch February 21, 2023 14:12
@xdavidwu
Copy link

Can we get a new release? We need the changes to requiresLegacyOpenSSLProvider() of this patch for migrating old projects to newer nodejs. (We can add --openssl-legacy-provider to NODE_OPTIONS by ourselves, but having this workaround implemented on the tool itself is still better.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants