Skip to content

Commit

Permalink
Update tests to run on active Node versions (#3327)
Browse files Browse the repository at this point in the history
* Update tests to run on active Node versions

* Update to GitHub actions checkout@v3 and setup-node@v3
  • Loading branch information
jnoordsij committed Feb 21, 2023
1 parent 3ab87c1 commit b116bf0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [12.x, 16.x, 17.x, 18.x]
node-version: [14.x, 16.x, 18.x, 19.x]
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
cache: 'npm'
node-version: ${{ matrix.node-version }}
Expand All @@ -36,6 +36,4 @@ jobs:
run: npm ci --legacy-peer-deps

- name: Run Tests
env:
NODE_OPTIONS: ${{ matrix.node-version == '17.x' && '--openssl-legacy-provider' || '' }}
run: npm test
4 changes: 0 additions & 4 deletions bin/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,6 @@ function isTTY() {
}

function requiresLegacyOpenSSLProvider() {
if (!process.version.startsWith('v17.') && !process.version.startsWith('v18.')) {
return false;
}

try {
require('crypto').createHash('md4').update('test').digest('hex');

Expand Down

0 comments on commit b116bf0

Please sign in to comment.