Fix not respecting return type of overridden Request::user() method. #1861
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
reviewed
Feb 19, 2024
|
You beat me to this! |
mad-briller
force-pushed
the
bug-1718
branch
from
6a00d74
to
dbeaf43
Compare
canvural
requested changes
Feb 20, 2024
I get that order does not matter (other than for aesthetics), but you would still have merge conflicts if two separate PRs placed files in the same spot at the end of the file. |
1 task
mad-briller
force-pushed
the
bug-1718
branch
2 times, most recently
from
4e9e12b
to
e131dcd
Compare
|
i'll get to this proper when i have some time after work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1718
Changes
Change RequestUserExtension to use the specific type of an overridden
Request::user()method