Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed return type of overridden Request::user() method. #1951

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fixed return type of overridden Request::user() method. #1951

wants to merge 1 commit into from

Conversation

sandeshjangam
Copy link

@sandeshjangam sandeshjangam commented May 19, 2024 •
edited

  • Added or updated tests

Resolves #1718

Changes

Change RequestUserExtension to use the specific type of an overridden Request::user() method

@sandeshjangam
Copy link
Author

sandeshjangam commented May 19, 2024 •
edited

Hello @calebdw,
Can we get his merged? Looks like issue is pending since Aug, 2023.

@calebdw
Copy link
Contributor

calebdw commented May 19, 2024

@sandeshjangam,

There's already an open PR to fix this issue: #1861

And I'm just a contributor, @canvural is the maintainer

@sandeshjangam
Copy link
Author

Ohkay. There was a conflict in the old PR so created a new PR.

@mad-briller
Copy link
Contributor

updated #1861 sorry, started a new job recently been busy

@calebdw
Copy link
Contributor

calebdw commented May 20, 2024

@mad-briller, congrats on the new job!

@szepeviktor
Copy link
Collaborator

@mad-briller After parking we want you back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return type when overwriting Request::user()
4 participants
@sandeshjangam @calebdw @mad-briller @szepeviktor