Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract recursive method from ConfigPostProcessor::__invoke() to avoid performance hit #102

Merged
merged 1 commit into from Jul 29, 2022
Merged

Extract recursive method from ConfigPostProcessor::__invoke() to avoid performance hit #102

merged 1 commit into from Jul 29, 2022

Commits on Jul 29, 2022

  1. Extract config processing from __invoke() 

    Replacements initialization depends on additional configuration from config, for
that reason it is delayed until config post processor is invoked.
However, __invoke() method is used recursively leading to unneccessary
reinitialization of Replacements and a significant performance hit.

Functionality is extracted into processConfig() to be used internally
for recursive calls.

Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
    @Xerkus
    Xerkus committed Jul 29, 2022
    Copy the full SHA
    07d4ce7 View commit details
    Browse the repository at this point in the history