Extract recursive method from ConfigPostProcessor::__invoke() to avoid performance hit #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacements initialization depends on additional configuration from config, for that reason it is delayed until config post processor is invoked. However, __invoke() method is used recursively leading to unneccessary reinitialization of Replacements and a significant performance hit. Functionality is extracted into processConfig() to be used internally for recursive calls. Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
|
I did not fix the psalm complaints that were covered by baseline and instead moved them along with extracted code. No tests are needed since behavior did not change. |
weierophinney
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Argghh.. thanks for spotting the recursion, @Xerkus; that would definitely lead to the performance issue reported. Nice work extracting that method!
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacementsinitialization depends on additional configuration from$config, forthat reason it is delayed until config post processor is invoked.
However,
__invoke()method is used recursively leading to unneccessaryreinitialization of
Replacementsand a significant performance hit.Functionality is extracted into
processConfig()to be used internallyfor recursive calls.