Upgraded codebase to comply with laminas/laminas-coding-standard:2.3.x
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ocramius
commented
Jul 6, 2022
Ocramius
commented
| Q | A |
|---|---|
| Documentation | no |
| Bugfix | no |
| BC Break | no |
| New Feature | no |
| RFC | no |
| QA | yes |
Signed-off-by: Renovate Bot <bot@renovateapp.com> | datasource | package | from | to | | ---------- | ------------------------------- | ----- | ----- | | packagist | laminas/laminas-coding-standard | 1.0.0 | 2.3.0 |
This was referenced Jul 6, 2022
|
Closing here in favor of #103 |
|
Note: I added lots of type improvements here - will likely reopen after #103 is merged, to look at the finer details |
Ocramius
added a commit
to Ocramius/laminas-diactoros
that referenced
this pull request
Jul 7, 2022
In laminas#104 (duplicate), we improved the types of internal and public API. These were mixed with coding style improvements. The coding style improvements have been merged separately via laminas#104, so this patch only includes the type/docblock improvements, which should ease the potential evolution of the API of this package.
Ocramius
added a commit
to Ocramius/laminas-diactoros
that referenced
this pull request
Jul 7, 2022
In laminas#104 (duplicate), we improved the types of internal and public API. These were mixed with coding style improvements. The coding style improvements have been merged separately via laminas#103, so this patch only includes the type/docblock improvements, which should ease the potential evolution of the API of this package.
Ocramius
added a commit
to Ocramius/laminas-diactoros
that referenced
this pull request
Jul 7, 2022
In laminas#104 (duplicate), we improved the types of internal and public API. These were mixed with coding style improvements. The coding style improvements have been merged separately via laminas#103, so this patch only includes the type/docblock improvements, which should ease the potential evolution of the API of this package.
|
Moved to #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.