Fix symfony/error-handler deprecations

[andrew-demb]

Q	A
Documentation	no
Bugfix	yes (?)
BC Break	no
New Feature	no
RFC	no
QA	no

Description

symfony/error-handler triggers deprecation errors in case of not (explicitly) specified return types when implemented interface have them declared (in phpdoc).
AFAIK they are triggered to make libraries migration to (possible) future declared return types more explicit.

It can be annoying to update all of libraries with such of changes, but these deprecation messages are pretty hard to silence :(

Here's log of there errors:

PHP Deprecated: Method "Psr\Http\Message\ServerRequestInterface::getParsedBody()" might add "array|object|null" as a native return type declaration in the future. Do the same in implementation "Laminas\Diactoros\ServerRequest" now to avoid errors or add an explicit @return annotation to suppress this message. in .../vendor/symfony/error-handler/DebugClassLoader.php on line 330
PHP Deprecated: Method "Psr\Http\Message\ServerRequestInterface::getAttribute()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Laminas\Diactoros\ServerRequest" now to avoid errors or add an explicit @return annotation to suppress this message. in .../vendor/symfony/error-handler/DebugClassLoader.php on line 330
PHP Deprecated: Method "Psr\Http\Message\StreamInterface::getMetadata()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Laminas\Diactoros\Stream" now to avoid errors or add an explicit @return annotation to suppress this message. in .../vendor/symfony/error-handler/DebugClassLoader.php on line 330

[Ocramius]

Honestly, type improvements are welcome, but these are just messed up symfony issues.

[andrew-demb]

Psalm fails the build because it cannot to read parameter type from interface, when there are phpdoc combines @inheritdoc and additional @return tag.

Error: src/ServerRequest.php:205:34: MissingParamType: Parameter $attribute has no provided type (see https://psalm.dev/154)
Error: src/ServerRequest.php:205:46: MissingParamType: Parameter $default has no provided type (see https://psalm.dev/154)

[andrew-demb]

Honestly, type improvements are welcome, but these are just messed up symfony issues.

Unfortunately I can't make types more precise for methods like \Laminas\Diactoros\ServerRequest::getAttribute [1].

Let's close then, we will try to hide errors from Symfony.

[1]

laminas-diactoros/src/ServerRequest.php

Lines 200 to 210 in c1a6111

	/**
	* {@inheritdoc}
	*/
	public function getAttribute($attribute, $default = null)
	{
	if (! array_key_exists($attribute, $this->attributes)) {
	return $default;
	}
	return $this->attributes[$attribute];
	}

[Ocramius]

My endorsement is to disable symfony/error-handler overall: it is a noxious component that effectively hooks in everything, worsening both runtime and developer experience.

The types refined in this particular patch were already precise enough in the interfaces declared by PSR-7, so IMO something else is happening.

Regardless of that, we are already working on improving types in #104 and #103.

Adding @return mixed on something where {@inheritDoc} already exists is really not improving on the situation, since mixed has little to no added value.