Do not test sys_tmp_dir if cache dir is provided. Fix #65. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Cremer <benjamin.cremer@check24.de>
bcremer
force-pushed
the
sys_tmp_dir-fix
branch
from
ff2ce88
to
775d829
Compare
Ocramius
approved these changes
Jan 29, 2024
| @@ -1,2 +1,12 @@ | |||
| { | |||
| "additional_checks": [ | |||
There was a problem hiding this comment.
Instead of adding a whole CI run, can we have a single test that uses exec on a dummy script, perhaps? 🤔
There was a problem hiding this comment.
Do you expect that test to check the exit code or how do we ensure that exactly the non-writable directory leads to the issue and not something else?
bcremer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #65