pull request for issue #65

[tck]

No description provided.

[Ocramius]

Needs some sort of test / reproducer, IMO.

[boesing]

I would suggest creating a directory in that test, change permissions to read-only using chmod and pass that to ini_set to modify sys temp dir for that test.

Having something like try {} finally {} to restore temp dir back to default to ensure test does not introduce side-effects to other tests.

[bcremer]

sys_temp_dir is of type PHP_INI_SYSTEM and thus cannot be set during runtime via ini_set.

Setting the TMPDIRenvironment variable works:
putenv('TMPDIR=/fasel').

Edit:
Seems like putenv('TMPDIR=/fasel') will also not work in the phpunit context.

[boesing]

I am not sure if this is a tmpdir only issue. Whenever a directory is used without write-permissions, that could lead to problems, no?

[sbenischke]

Any update on this topic?

In my opinion the sys_tmp_dir should be used as a fallback after the try to initialize the configured directory. So at least there is the possibility to get this adapter working, if the sys_tmp_dir is neither readable or writeable.

[boesing]

Once the requested changes are applied, we can move on.
Feel free to use these changes to create a new PR with added test(s) or wait until the author is responding.

[bcremer]

I stumbled about this problem during a docker run --read-only deployment of an mezzio application.

I came up with the same fix as @tck. Building a reproducer as phpunit testcase is tricky because sys_tmp_dir cannot be modified during runtime, see: #73 (comment).

A standalone reproducer looks like the following:

<?php

require __DIR__  . '/vendor/autoload.php';

putenv('TMPDIR=/fasel');

// the following will throw an exception bacause `/fasel` does not exists even though the cache dir was explicitly overwritten
new \Laminas\Cache\Storage\Adapter\FilesystemOptions(['cacheDir' => '/tmp']);

PHP Fatal error:  Uncaught Laminas\Cache\Exception\InvalidArgumentException: Cache directory '/fasel' not found or not a directory in /home/apidev/current/laminas-cache-storage-adapter-filesystem/src/FilesystemOptions.php:440

If nobodoy has an idea how to codify the reproducer in phpunit I would suggest to move on and merge the PR as is.

[boesing]

Might be possible to modify the tmpdir setting via php CLI command when running a specific test group.

We could create a test, add a group to it, use that group in additional_checks when running php vendor/bin/phpunit along with the -d parameter to modify the temp dir target, add a check to that test that it skips the execution when tmp directory is readable and that should do the trick, no?

The check in the test could look like:

if (is_writable(sys_get_temp_dir())) { 
    self::markAsRisky(); 
    self::markTestSkipped('Test has to be executed in read-only environment...');
}

---

Here is an example on how addtional_checks could look like:

https://github.com/laminas/laminas-cache/blob/ce069bc6c0c10abf13a51da1b0153090dc1caf0c/.laminas-ci.json#L4-L11

[bcremer]

@boesing Implemented in a separate PR: #84