Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1 #5541

Merged
merged 8 commits into from
Jan 19, 2023
Merged

chore(deps): bump sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1 #5541

merged 8 commits into from
Jan 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 21, 2022 •
edited by michaelbeaumont

Bumps sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1.

Covers #5527 and #5547. Blocked on waiting on upstream v0.26.1 libs

Changelog: chore(deps): bump sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1, bump k8s libs from 0.25.4 to 0.26.1

Release notes

Sourced from sigs.k8s.io/controller-tools's releases.

v0.11.1

What's Changed

Full Changelog: kubernetes-sigs/controller-tools@v0.11.0...v0.11.1

v0.11.0

What's Changed

New Contributors

Full Changelog: kubernetes-sigs/controller-tools@v0.10.0...v0.11.0

Commits
  • 9d91b25 Merge pull request #755 from k8s-infra-cherrypick-robot/cherry-pick-754-to-re...
  • d4ef1b3 Revert ":bug: Fix the generation of listType=set"
  • cce03d2 Merge pull request #753 from kubernetes-sigs/fix-generation-of-sets
  • 521024d Merge pull request #750 from kubernetes-sigs/dependabot/go_modules/github.com...
  • 82a53e3 🐛 Fix the generation of listType=set
  • 309e03b 🌱 Bump github.com/onsi/gomega from 1.24.1 to 1.24.2
  • 68d9d38 Merge pull request #748 from kubernetes-sigs/dependabot/go_modules/golang.org...
  • dae3016 🌱 Bump golang.org/x/tools from 0.3.0 to 0.4.0
  • 31118e3 Merge pull request #749 from JoelSpeed/bump-1.26
  • dfc0dc5 Bump Kubernetes deps to v1.26.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team, bartsmykla and lobkovilya and removed request for a team December 21, 2022 17:42
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 21, 2022
@michaelbeaumont
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from bfd3884 to f8ecc28 Compare December 22, 2022 09:02
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Jan 11, 2023
Merged
@lahabana
Copy link
Contributor

@dependabot recreate

@michaelbeaumont
Copy link
Contributor

@lahabana This isn't mergeable until k8s libs v0.26.1 are released. SOrry maybe it's easy to miss in the PR description. I've added changes to this PR already to make it work once that version is released.

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 163dbf5 to 42843c5 Compare January 12, 2023 23:54
@lahabana
Copy link
Contributor

@michaelbeaumont yes I noticed after the fact. Yes I didn't read the PR description until later. Probably worth adding a blocked label for these kind a situation to make it more obvious

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 42843c5 to 868ee02 Compare January 17, 2023 13:48
dependabot bot and others added 6 commits January 19, 2023 10:34
@dependabot @michaelbeaumont
chore(deps): bump sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1
f015397 
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.10.0 to 0.11.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-tools@v0.10.0...v0.11.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@michaelbeaumont
chore(deps): bump sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.1
3728b8e 
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.13.1 to 0.14.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.13.1...v0.14.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: check AddEventHandler error
3df2cd2 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: deprecated functions
f222281 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: update CRDs
b9d6685 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: update golden files
79d50a6 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 3ce2fc7 to 79d50a6 Compare January 19, 2023 09:41
@michaelbeaumont michaelbeaumont mentioned this pull request Feb 21, 2023
Open
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) January 19, 2023 09:57
@michaelbeaumont michaelbeaumont force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 40d7c8c to 861123a Compare January 19, 2023 13:08
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Jan 19, 2023 •
edited

@lahabana looks like there was an unintentional breaking change in the fake_client, see the last commit if you care. It's a little hacky because we should really only be adding an index in one place, it's exposing the internals to the test too much. But the only other solution I can imagine might work would be to expose the bootstrap k8s plugin code (see createSecretClient) for use by the tests.

In [It] at: github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:78 @ 01/19/23 10:02:41.58> Enter [BeforeEach] MeshDefaultsReconciler - github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:33 @ 01/19/23 10:02:41.559
< Exit [BeforeEach] MeshDefaultsReconciler - github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:33 @ 01/19/23 10:02:41.559 (0s)
> Enter [It] should not create a new default policy if it was deleted - github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:88 @ 01/19/23 10:02:41.559
2023-01-19T10:02:41Z	INFO	defaults.mesh	ensuring default resources for Mesh exist	{"mesh": "default"}
2023-01-19T10:02:41Z	INFO	defaults.mesh	default TrafficPermission created	{"mesh": "default", "name": "allow-all-default"}
2023-01-19T10:02:41Z	INFO	defaults.mesh	default TrafficRoute created	{"mesh": "default", "name": "route-all-default"}
2023-01-19T10:02:41Z	INFO	defaults.mesh	default Timeout created	{"mesh": "default", "name": "timeout-all-default"}
2023-01-19T10:02:41Z	INFO	defaults.mesh	default CircuitBreaker created	{"mesh": "default", "name": "circuit-breaker-all-default"}
2023-01-19T10:02:41Z	INFO	defaults.mesh	default Retry created	{"mesh": "default", "name": "retry-all-default"}
[FAILED] Unexpected error:
    <*errors.withStack | 0xc000b295d8>: {
        error: <*errors.withMessage | 0xc0004b2760>{
            cause: <*errors.withStack | 0xc000b295a8>{
                error: <*errors.withMessage | 0xc0004b2740>{
                    cause: <*errors.withStack | 0xc000b29578>{
                        error: <*errors.withMessage | 0xc0004b2720>{
                            cause: <*errors.withStack | 0xc000b29548>{
                                error: <*errors.withMessage | 0xc0004b2700>{
                                    cause: <*errors.errorString | 0xc0003ff620>{
                                        s: "List on GroupVersionKind /v1, Kind=Secret specifies selector on field type, but no index with name type has been registered for GroupVersionKind /v1, Kind=Secret",
                                    },
                                    msg: "failed to list k8s Secrets",
                                },
                                stack: [0x3184f5e, 0x31803f1, 0x28e1bff, 0x29a5bb7, 0x29aa417, 0x29a899f, 0x307be7f, 0x33f39ff, 0x33f3466, 0x30f7631, 0x3115a12, 0x4a1e61],
                            },
                            msg: "could not retrieve signing key from secret manager",
                        },
                        stack: [0x29a5bcd, 0x29aa417, 0x29a899f, 0x307be7f, 0x33f39ff, 0x33f3466, 0x30f7631, 0x3115a12, 0x4a1e61],
                    },
                    msg: "could not create default Dataplane Token Signing Key",
                },
                stack: [0x29a8d1c, 0x307be7f, 0x33f39ff, 0x33f3466, 0x30f7631, 0x3115a12, 0x4a1e61],
            },
            msg: "could not create default mesh resources",
        },
        stack: [0x307c385, 0x33f39ff, 0x33f3466, 0x30f7631, 0x3115a12, 0x4a1e61],
    }
    could not create default mesh resources: could not create default Dataplane Token Signing Key: could not retrieve signing key from secret manager: failed to list k8s Secrets: List on GroupVersionKind /v1, Kind=Secret specifies selector on field type, but no index with name type has been registered for GroupVersionKind /v1, Kind=Secret
occurred
In [It] at: github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:78 @ 01/19/23 10:02:41.58
< Exit [It] should not create a new default policy if it was deleted - github.com/kumahq/kuma/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go:88 @ 01/19/23 10:02:41.58 (21ms)

@michaelbeaumont
fix: use index in test
484d284 
See the unintentional breaking change in:
kubernetes-sigs/controller-runtime#2025

There's now an error thrown if a field selector is used but an
index wasn't registered but previously it was simply ignored.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 861123a to 484d284 Compare January 19, 2023 13:14
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) January 19, 2023 13:17
@michaelbeaumont
Merge remote-tracking branch 'origin/master' into dependabot/go_modul…
bdbc41f 
…es/sigs.k8s.io/controller-tools-0.11.1

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch from 0b5e740 to bdbc41f Compare January 19, 2023 13:40
@michaelbeaumont michaelbeaumont merged commit d81a5af into master Jan 19, 2023
@michaelbeaumont michaelbeaumont deleted the dependabot/go_modules/sigs.k8s.io/controller-tools-0.11.1 branch January 19, 2023 14:31
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @lahabana