Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump golang.org/x/tools from 0.3.0 to 0.4.0 #748

Merged
merged 1 commit into from Dec 16, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2022

Bumps golang.org/x/tools from 0.3.0 to 0.4.0.

Release notes

Sourced from golang.org/x/tools's releases.

gopls/v0.4.0

  • Improved support for working with modules (@​ridersofrohan). A detailed walk-through of the new features can be found here. A quick summary:
    • Use the -modfile flag to suggest which modules should be added/removed from the go.mod file, rather than editing it automatically.
    • Suggest dependency upgrades in-editor and provide additional language features, such as formatting, for the go.mod file.
  • Inverse implementations (@​muirdm). "Go to implementations" on a concrete type will show the interfaces it implements.
  • Completion improvements (@​muirdm). Specifically, improved completion for keywords. Also, offer if err != nil { return err } as a completion item.
  • Jumping to definition on an import statement returns all files as definition locations (@​danishprakash).
  • Support for running go generate through the editor, via a code lens (@​marwan-at-work).
  • Command-line support for workspace symbols (@​daisuzu).

Opt-in:

  • Code actions suggesting gofmt -s-style simplifications (@​ridersofrohan). To get these on-save, add the following setting:
"[go]": {
	"editor.codeActionsOnSave": {
		"source.fixAll": true,
	}
}
  • Code actions suggesting fixes for type errors, such as missing return values (goreturns-style), undeclared names, unused parameters, and assignment statements that should be converted from := to = (@​ridersofrohan). Add the following to your gopls settings to opt-in to these analyzers. In the future, they will be on by default and high-confidence suggested fixes may be applied on save. See additional documentation on analyzers here.
"gopls": {
	"analyses": {
		"fillreturns": true,
                "undeclaredname": true,
                "unusedparams": true,
                "nonewvars": true,
	}
}
  • Further improvements in the support for multiple concurrent clients (@​findleyr). See #34111 for all details.

For a complete list of the issues resolved, see the gopls/v0.4.0 milestone.

gopls/v0.3.4

gopls/v0.3.3

  • Support for workspace symbols. (@​daisuzu)
  • Various completion improvements, including fixes for completion in code that doesn't parse. (@​muirdm)
  • Limit diagnostic concurrency, preventing huge spikes in memory usage that some users encountered. (@​heschik)
  • Improved handling for URIs containing escaped characters. (@​heschik)
  • Module versions from "go list" in pkg.go.dev links. (@​ridersofrohan)

... (truncated)

Commits
  • aee3994 gopls/internal/lsp/fake: in (*Workdir).RenameFile, fall back to read + write
  • fe60148 go.mod: update golang.org/x dependencies
  • c9ea9a7 gopls/internal/regtest: add a test for the case when the renaming package's p...
  • bf5db81 gopls/internal/lsp/cache: improve ad-hoc warning for nested modules
  • aa9f4b2 go/analysis: document that facts are gob encoded in one gulp
  • bdcd082 internal/gcimporter: skip tests earlier when 'go build' is not available
  • 2ad6325 gopls/internal/lsp/cache: expand ImportPath!=PackagePath comment
  • 52c7b88 gopls/internal/robustio: only define ERROR_SHARING_VIOLATION on Windows
  • 4f69bf3 gopls/internal/lsp/cache: narrow reloadOrphanedFiles to open files
  • 6002d6e gopls/internal/regtest/misc: test Implementations + vendor
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2022
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/tools-0.4.0 branch from 1f2596f to dae3016 Compare December 16, 2022 14:14
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2022
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2022
@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: camilamacedo86, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68d9d38 into master Dec 16, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/golang.org/x/tools-0.4.0 branch December 16, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants