Skip to content

Commit

Permalink
Merge pull request #1947 from upalatucci/loadbalancer-in-progress
Browse files Browse the repository at this point in the history
CNV-39941: in progress instead of pending for SSH load balancer
  • Loading branch information
openshift-merge-bot[bot] committed May 15, 2024
2 parents 325cab9 + 5cb104a commit af8fd1d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 2 additions & 0 deletions locales/en/plugin__kubevirt-plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,7 @@
"In": "In",
"In order to add a new source for {{osName}} you will need to delete the following PVC:": "In order to add a new source for {{osName}} you will need to delete the following PVC:",
"In process": "In process",
"In progress": "In progress",
"Include all values from existing config maps, secrets or service accounts (as disk)": "Include all values from existing config maps, secrets or service accounts (as disk)",
"Increment": "Increment",
"Indications": "Indications",
Expand Down Expand Up @@ -1221,6 +1222,7 @@
"This is a CD-ROM boot source": "This is a CD-ROM boot source",
"This key will override the SSH key secret set on the template": "This key will override the SSH key secret set on the template",
"This Persistent Volume Claim will be created using a DataVolume through Containerized Data Importer (CDI)": "This Persistent Volume Claim will be created using a DataVolume through Containerized Data Importer (CDI)",
"This process can take 1-2 minutes to complete.": "This process can take 1-2 minutes to complete.",
"This user is not allowed to edit this boot source": "This user is not allowed to edit this boot source",
"This VirtualMachine has": "This VirtualMachine has",
"This VirtualMachine is down. Please start it to access its console.": "This VirtualMachine is down. Please start it to access its console.",
Expand Down
10 changes: 6 additions & 4 deletions src/utils/components/SSHAccess/components/SSHServiceState.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { FC } from 'react';

import { IoK8sApiCoreV1Service } from '@kubevirt-ui/kubevirt-api/kubernetes';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { FlexItem } from '@patternfly/react-core';
import { FlexItem, Tooltip } from '@patternfly/react-core';
import { CheckCircleIcon, WarningTriangleIcon } from '@patternfly/react-icons';

import { SERVICE_TYPES } from '../constants';
Expand All @@ -23,9 +23,11 @@ const SSHServiceStateIcon: FC<SSHServiceStateIconProps> = ({ sshService, sshServ
return (
<FlexItem>
{!isLoadBalancerBonded(sshService) ? (
<div>
<WarningTriangleIcon color="var(--pf-global--warning-color--100)" /> {t('Pending')}{' '}
</div>
<Tooltip content={t('This process can take 1-2 minutes to complete.')}>
<div>
<WarningTriangleIcon color="var(--pf-global--warning-color--100)" /> {t('In progress')}{' '}
</div>
</Tooltip>
) : (
<div>
<CheckCircleIcon color="var(--pf-global--success-color--100)" /> {t('Ready')}{' '}
Expand Down

0 comments on commit af8fd1d

Please sign in to comment.